Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace yarn with npm across repo #25

Merged
merged 5 commits into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/nodejs-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: 18
cache: 'yarn'
cache: 'npm'

- name: Install dependencies
run: yarn install
run: npm install

- name: Run lint
run: yarn lint
run: npm run lint

- name: Run tests
run: yarn test --silent
run: npm run test --silent
jmcook1186 marked this conversation as resolved.
Show resolved Hide resolved

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Add and commit:

Commit your changes in logical chunks. Please do not push all changes in one commit.

> Run `yarn fix` before commiting for not having conflict with CI linter.
> Run `npm run fix` before commiting for not having conflict with CI linter.

Please adhere to these [Commit message guidelines](#commit-message-guidelines)
or your code is unlikely be merged into the main project.
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@
"zod": "^3.22.4"
},
"engines": {
"node": "18",
"yarn": ">=1.22",
"npm": "8.19.2"
"node": ">=18",
"npm": ">=8"
},
"files": [
"build"
Expand Down Expand Up @@ -68,7 +67,8 @@
"coverage": "jest --verbose --coverage",
"fix:package": "fixpack",
"lint": "gts lint",
"prepublish": "yarn build",
"prepublish": "npm run build",
"test": "jest --verbose"
}
}
jmcook1186 marked this conversation as resolved.
Show resolved Hide resolved