-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed trimspace in write method #38
base: v1
Are you sure you want to change the base?
Conversation
trimspace causes number of bytes wirtten to be not equal to number of bytes requested to write - this causes an error in multiwriter
@mariussturm i've just noticed that somehow this PR also will update README.md - this was not my intent, please ignore commit #8a6a140bfa5cdfce8768648e8a7ddf3c13b04be9 |
@Bobby-88 under what conditions exactly do you have problems with the trimspace? |
Sorry for delay.
|
@mariussturm I think the writer should respect provided data to send it as is, even with leading white spaces. Problem with odd UI should be resolved in the Graylog web interface logic, not log writer. |
This seems sensible. Especially if the only reason to trim it is to fix the UI. As thaod pointed out, it's more logical to do this in the UI code. |
This fixes #37
Trimspace causes number of bytes wirtten to be not equal to number of bytes requested to write - this causes an error in multiwriter
Happy to help with other tests if needed