Update

GraphBLAS · Aug 28, 2024 · 9e3ccfd · 9e3ccfd
1 parent 4925e48
commit 9e3ccfd
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 14 deletions.
diff --git a/examples/benchmark_read.c b/examples/benchmark_read.c
@@ -42,10 +42,10 @@ double compute_variance(double* x, size_t n) {
 
 void flush_cache() {
 #ifdef __APPLE__
-  system("bash -c \"sync && sudo purge\"");
+  int rv = system("bash -c \"sync && sudo purge\"");
 #elif __linux__
-  system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
-         "/proc/sys/vm/drop_caches\"");
+  int rv = system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
+                  "/proc/sys/vm/drop_caches\"");
 #else
   static_assert(false);
 #endif

diff --git a/examples/benchmark_read_parallel.c b/examples/benchmark_read_parallel.c
@@ -42,10 +42,10 @@ double compute_variance(double* x, size_t n) {
 
 void flush_cache() {
 #ifdef __APPLE__
-  system("bash -c \"sync && sudo purge\"");
+  int rv = system("bash -c \"sync && sudo purge\"");
 #elif __linux__
-  system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
-         "/proc/sys/vm/drop_caches\"");
+  int rv = system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
+                  "/proc/sys/vm/drop_caches\"");
 #else
   static_assert(false);
 #endif

diff --git a/examples/benchmark_write.c b/examples/benchmark_write.c
@@ -42,10 +42,10 @@ double compute_variance(double* x, size_t n) {
 
 void flush_cache() {
 #ifdef __APPLE__
-  system("bash -c \"sync && sudo purge\"");
+  int rv = system("bash -c \"sync && sudo purge\"");
 #elif __linux__
-  system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
-         "/proc/sys/vm/drop_caches\"");
+  int rv = system("bash -c \"sync\" && sudo sh -c \"/usr/bin/echo 3 > "
+                  "/proc/sys/vm/drop_caches\"");
 #else
   static_assert(false);
 #endif
@@ -54,9 +54,9 @@ void flush_cache() {
 
 void flush_writes() {
 #ifdef __APPLE__
-  system("bash -c \"sync\"");
+  int rv = system("bash -c \"sync\"");
 #elif __linux__
-  system("bash -c \"sync\"");
+  int rv = system("bash -c \"sync\"");
 #else
   static_assert(false);
 #endif
@@ -65,7 +65,7 @@ void flush_writes() {
 void delete_file(char* file_name) {
   char command[2048];
   snprintf(command, 2047, "rm %s", file_name);
-  system(command);
+  int rv = system(command);
 }
 
 int main(int argc, char** argv) {

diff --git a/include/binsparse/detail/shm_tools.h b/include/binsparse/detail/shm_tools.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include <stddef.h>
+#include <stdio.h>
 #include <sys/ipc.h>
 #include <sys/shm.h>
 #include <sys/stat.h>

diff --git a/include/binsparse/matrix_market/matrix_market_inspector.h b/include/binsparse/matrix_market/matrix_market_inspector.h
@@ -33,8 +33,10 @@ bsp_mm_metadata bsp_mmread_metadata(char* file_path) {
 
   bsp_mm_metadata metadata;
 
-  fscanf(f, "%%%%MatrixMarket matrix %s %s %s\n", metadata.format,
-         metadata.type, metadata.structure);
+  int read_items = fscanf(f, "%%%%MatrixMarket matrix %s %s %s\n",
+                          metadata.format, metadata.type, metadata.structure);
+
+  assert(read_items == 3);
 
   for (size_t i = 0; i < strlen(metadata.structure); i++) {
     metadata.structure[i] = tolower(metadata.structure[i]);