Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Upgrades #9512

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

Go Upgrades #9512

wants to merge 42 commits into from

Conversation

aran
Copy link
Contributor

@aran aran commented Aug 28, 2024 •
edited
Loading

Description
As discussed in office hours, draft PR showing go dependency upgrades.

  • Many dependencies have published breaking changes so tests and fixes are needed in Skaffold. These are at the top of the stack.
  • The commit containing the result of 'go mod vendor' is too large for me to push to Github. I hit HTTP 400 errors. This has been broken up into many smaller commits to fit under the github limits.

@aran
Copy link
Contributor Author

aran commented Aug 28, 2024

cc @renzodavid9 as discussed

@aran
chore: go get -u ./...
c6cbf4a 
Summary: go.mod and go.sum upgrades

Test Plan: Tests and fixes in later commits.
@aran
chore: go mod tidy
6ec817f 
Summary: go.mod/go.sum tidy after upgrade

Test Plan: Tests and fixes in later commits
@aran
chore: go mod vendor - cloud.google.com
42a2552
@aran
chore: go mod vendor - dario.cat
2a999e8
@aran
chore: go mod vendor - github.com/[A-Z]*
b8affba
@aran
chore: go mod vendor - github.com/[a-h]*
b7d2ed2
@aran
chore: go mod vendor - github.com/[i-p]*
ef02b7d
@aran
chore: go mod vendor - removal of github.com/russross
ae4022f
@aran
chore: go mod vendor - github.com/rivo minus the gif
f4f5590
@aran
chore: go mod vendor - github.com/rivo/tview/tview.gif
63a275a
@aran
chore: go mod vendor - github.com/s*
63fc22a
@aran
chore: go mod vendor - github.com/t*
7e3ccc1
@aran
chore: go mod vendor - github.com/x*
c9996ec
@aran
chore: go mod vendor - github.com removals
0574273
@aran
chore: go mod vendor - go.lsp.dev, go.mongodb.org
15da05f
@aran
chore: go mod vendor - go.opentelemetry.io
82a3303
@aran
chore: go mod vendor - go.uber.org, golang.org
585b71e
@aran
chore: go mod vendor - google.golang.org
0d87619
@aran
chore: go mod vendor - k8s.io/api
13c0fa9
@aran
chore: go mod vendor - k8s.io/apimachinery
8ade0c2
@aran
chore: go mod vendor - k8s.io/client-go
7b1e255
@aran
chore: go mod vendor - k8s.io remaining
ab3c9d8
@aran
chore: go mod vendor - vendor/modules.txt
8978c3a
@aran
chore: go mod vendor - sigs.k8s.io/cli-utils
128d269
@aran
chore: go mod vendor - sigs.k8s.io/kind
4f2195f
@aran
chore: go mod vendor - sigs.k8s.io/kustomize/api/[a-h]*
e6ae60f
@aran
chore: go mod vendor - sigs.k8s.io/kustomize/api remaining
01abcbf
@aran
chore: go mod vendor - sigs.k8s.io/kustomize/ remaining
a3b209a
@aran
chore: go mod vendor - sigs.k8s.io/structured-merge-diff
62368a9
@aran
chore: go mod vendor - sigs.k8s.io/yaml
697b180
@aran
chore: go mod vendor - go.starlark.net gopkg.in
04d0e53
@aran
Fix: compile errors in pkg/skaffold/docker/image.go
79fe94c 
Summary: Docker API has changed

Test Plan: Test when full project compiles
@aran
fix: compile errors in pkg/skaffold/build/local/prune.go
55e229d 
Summary: Docker API has changed

Test Plan: Test when full project compiles
@aran
fix: compile errors in pkg/skaffold/docker/auth{_test}.go
b7ab530 
Summary: Thread a context down to where an API change requires it

Test Plan: Test when the full project compiles.
@aran
fix: compile errors in pkg/skaffold/docker/authenticators.go
d6d9128
@aran
fix: compile errors in testutil/fake_image_api.go
7809328
@aran
fix: convert types.ContainerListOptions to container.ListOptions
6404f3e
@aran
fix: add a CheckReadAccess implementation for buildpacks image fetcher
a43dd24
@aran
Create a logger for buildpacks build
ae4c69f
@aran
fix: Adapt logrus-based logger to buildpack logger for GetEnv method
fe777c4
@aran
fix: Update moby/buildkit API calls in pkg/skaffold/docker/parse.go
8088199
@aran
fix: vendor patch github.com/buildpacks/lifecycle/buildpack/dockerfil…
4fbb1e9 
…e.go to match updated moby/buildkit API
@aran
Copy link
Contributor Author

aran commented Sep 8, 2024

@renzodavid9 updated now that I figured out the github commit size issue.

This may be worth reviewing with your teammate regardless of the ssh issue, as updating dependencies is probably a good idea overall.

Do note the one fix that is in vendor/.

aran added a commit to aran/skaffold that referenced this pull request Sep 8, 2024
@aran
fix: Set the client DialContext to the connhelper dialer when accessi…
ff855fd 
…ng an SSH DOCKER_HOST

Summary: Fixes GoogleContainerTools#9484

Test Plan: Tested skaffold over a ssh connection to minikube.

This was tested with and without GoogleContainerTools#9512 in place.
@aran aran mentioned this pull request Sep 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aran