Identified issues with tfdv_basic_spending.ipynb #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
training-data-analyst/courses/machine_learning/deepdive2/production_ml/solutions/tfdv_basic_spending.ipynb might be having mistakes - data location not disclosed asked candidate to write code to read data (train and test) in the first few cells of the notebook - unnecessary comment confusing candidate (could be from taxi example but relevant here )-> 1) Notice that there are no examples with values for pickup_census_tract. This is an opportunity for dimensionality reduction! 2) Try switching between the log and linear scales, and notice how the log scale reveals much more detail about the payment_type categorical feature
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
training-data-analyst/courses/machine_learning/deepdive2/production_ml/solutions/tfdv_basic_spending.ipynb might be having mistakes
Here are those comments:-
- Notice that there are no examples with values for pickup_census_tract. This is an opportunity for dimensionality reduction!
- Try switching between the log and linear scales, and notice how the log scale reveals much more detail about the payment_type categorical feature