Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Identity Center in Opal provider #1715

Merged

Conversation

ken-opal
Copy link
Contributor

@ken-opal ken-opal commented Jun 5, 2023

Adds minor updates for the Opal provider:

  • When permission sets are imported, we check the parent account and format the tf resource name as {acc_name}_{permission_set_name} so as to disambiguate across accounts
  • Fixes a bug where if you have two resources called "x", and then another called "x_2", then two "x_2"s are created, leading to an import error. Instead, we disambiguate using a UUID prefix, which should likely not cause collisions.

- When permission sets are imported, we check the parent account
and format the tf resource name as `{acc_name}_{permission_set_name}`
so as to disambiguate across accounts
- Fixes a bug where if you have two resources called "x", and then
another called "x_2", then two "x_2"s are created, leading to an import
error. Instead, we disambiguate using a UUID prefix, which should likely
not cause collisions.
@sergeylanzman sergeylanzman merged commit c1221cb into GoogleCloudPlatform:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants