feat: APIs for Backend Changes for Default Values #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asthamohta
commented
Dec 17, 2024
asthamohta
requested review from
darshan-sj and
Deep1998
and removed request for
a team
asthamohta
changed the title
asthamohta
commented
Dec 17, 2024
darshan-sj
reviewed
Dec 18, 2024
darshan-sj
approved these changes
Dec 18, 2024
Deep1998
reviewed
Dec 18, 2024
| return nil, err | ||
| } | ||
| } else { | ||
| spannerAccessor, err = spanneraccessor.NewSpannerAccessorClientImpl(ctx) |
There was a problem hiding this comment.
Dont have full context but Why are we multiplexing this here? Seems like this project id based if else logic should reside inside NewSpannerAccessorClientImpl() that creates accessor without spanner client if fields are empty.
Deep1998
reviewed
Dec 18, 2024
| } | ||
| return &ExpressionVerificationAccessorImpl{ | ||
| SpannerAccessor: spannerAccessor, | ||
| }, nil | ||
| } | ||
|
|
||
| type DDLVerifier interface { |
There was a problem hiding this comment.
nit: in general its good practice to document behaviour for methods in interface.
Deep1998
reviewed
Dec 18, 2024
| @@ -79,6 +107,15 @@ func (ev *ExpressionVerificationAccessorImpl) VerifyExpressions(ctx context.Cont | |||
| return verifyExpressionsOutput | |||
| } | |||
|
|
|||
| func (ev *ExpressionVerificationAccessorImpl) RefreshSpannerClient(ctx context.Context, project string, instance string) error { | |||
| spannerClient, err := spannerclient.NewSpannerClientImpl(ctx, fmt.Sprintf("projects/%s/instances/%s/databases/%s", project, instance, "smt-staging-db")) | |||
There was a problem hiding this comment.
"smt-staging-db" should be a constant string across the codebase.
Deep1998
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR contains APIs which will be used for Default Value migrations. For completeness on usage of these API, refer to the following PR: #952