New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Check Constraint - Backend code changes #945

Open

taherkl wants to merge 38 commits into GoogleCloudPlatform:master from ollionorg:support-check-constraint-backend

taherkl commented Nov 27, 2024 •

edited

Loading

Backend Support for Check Constraint

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

Tests pass
Appropriate changes to README are included in PR

Backend code changes to support CHECK CONSTRAINTS

Added DB Collation regex on the constants
Added helper function for generating Check constraints ID
Updated Conv schema to support Check Constraints
CRUD operation for check constraints expressions to Spanner DDL
Added regex pattern validation to check constraints name, table name and database collation


          Check constraint backend (#9)

75deab6

Backend Support for Check Constraint

pull-request-size bot added the size/XL label

taherkl changed the title ~~Check constraint backend (#9)~~ Add Support for Check Constraint - Backend code changes

taherkl added 3 commits

November 27, 2024 20:12


          Merge remote-tracking branch 'upstream/master'

472b979


          sync master

40e9798


          update api

60e6635

asthamohta reviewed

View reviewed changes

sources/common/toddl.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

sources/common/toddl_test.go Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

spanner/ddl/ast.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

spanner/ddl/ast_test.go Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

spanner/ddl/ast_test.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/api/schema.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/api/schema.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/api/schema.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/table/review_table_schema.go Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/table/update_table_schema.go Show resolved Hide resolved

Collaborator

asthamohta commented Nov 28, 2024

There are two things missing in this PR:

Either a separate PR or in the same PR we need ot make setting instance and project name mandatory on the page before schema migration.
The validation call is not called when prepare migration is clicked.

bharadwaj-aditya reviewed

View reviewed changes

internal/helpers.go Outdated Show resolved Hide resolved

bharadwaj-aditya requested changes

View reviewed changes

internal/reports/report_helpers.go Show resolved Hide resolved

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

spanner/ddl/ast.go Outdated Show resolved Hide resolved

spanner/ddl/ast.go Outdated Show resolved Hide resolved

webv2/api/schema.go Outdated Show resolved Hide resolved

taherkl and others added 6 commits

November 28, 2024 15:28


          fix PR comment

d3ef5b9


          Merge branch 'GoogleCloudPlatform:master' into support-check-constrai…

85bc610

…nt-backend


          remove api call to while validating constraints

8eb044c


          Fixed db collation regex to remove collation name from the results

954c368


          renamed function name to formatCheckConstraints and added check if co…

fc4c19f

…nstraint name is empty


          fixed PR comments

1d2e5e3

pull-request-size bot added size/XXL and removed size/XL labels


          added test case for the empty check constraint name

449e6f8

taherkl requested review from asthamohta and VardhanThigle

December 10, 2024 11:14


          Added test case for the column rename for check constraint

41424a2

bharadwaj-aditya reviewed

View reviewed changes

sources/mysql/infoschema.go Outdated Show resolved Hide resolved

akashthawaitcc and others added 15 commits

December 13, 2024 01:05


          1. Refactored GetConstraint function

3f9b616

2. Fixed inforschema unit tests


          added comment at handling case for check constraints

df31d35


          reverted white spaces

491e5db


          reverted white spaces

e64bd55


          nit: doesCheckConstraintNameExist

67c71c2


          added comments for doesCheckConstraintNameExist


          PR and UT fixes

ea92a24


          Merge branch 'master' into support-check-constraint-backend

5f20127


          fix UT

eb1e4b0


          UT fix

31b2ac1


          Removed isCheckConstraintsTablePresent function

283e358


          moved regex globally

79332a4


          Fix UT

430bebc


          fixed UT

df77473


          fixed handling of the constraints

6fb655d

asthamohta reviewed

View reviewed changes

internal/mapping.go Outdated Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

sources/common/toddl_test.go Show resolved Hide resolved

asthamohta reviewed

View reviewed changes

webv2/api/schema_test.go Outdated Show resolved Hide resolved

Collaborator

asthamohta commented Dec 16, 2024

Where are the ADD and DELETE APIs for check constraints?

asthamohta reviewed

View reviewed changes

webv2/table/review_table_schema_test.go Show resolved Hide resolved

akashthawaitcc and others added 6 commits

December 16, 2024 20:18


          removed unused function

86bbab7


          added unit tests for incompatable name

69d91ca


          Combined unit tests

91c2b9a


          added test case for the renaming column having substring of other column

a0ec7eb


          added the query changes which return distinct value

0954a27


          Merge branch 'master' into support-check-constraint-backend

0428c80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

akashthawaitcc akashthawaitcc left review comments

bharadwaj-aditya bharadwaj-aditya requested changes

asthamohta asthamohta left review comments

VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Requested changes must be addressed to merge this pull request.

Labels