Default Value: Spanner Metadata Accessor #886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NirnayaSindhuSuthari
commented
Jul 24, 2024
•
NirnayaSindhuSuthari
commented
- DefaultValue of type DefaultValue is added in the columnDef struct.
- Validity of Default Value by spanner is checked by IsSpannerSupportedStatement .
- isValidSpannerStatement fires query SELECT CAST( (statement) AS (column type) ) to spanner on metadata database.
- Default clause is added in the SQL tab for spanner supported default values.
NirnayaSindhuSuthari
requested review from
manitgupta and
aksharauke
and removed request for
a team
NirnayaSindhuSuthari
changed the base branch from
master
to
feature/default-value
darshan-sj
reviewed
Aug 5, 2024
accessors/spanner/spannermetadataaccessor/clients/spanner_metadata_client.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/clients/spanner_metadata_client_test.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Aug 7, 2024
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Aug 7, 2024
accessors/spanner/spannermetadataaccessor/spanner_metadata_accessor.go
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Aug 7, 2024
NirnayaSindhuSuthari
force-pushed
the
spannerMetadataAccessor
branch
from
51cb3a9 to
547b6bd
Compare
asthamohta
reviewed
Aug 9, 2024
asthamohta
reviewed
Aug 9, 2024
| @@ -78,7 +78,7 @@ func (ci *ConvImpl) SchemaConv(migrationProjectId string, sourceProfile profiles | |||
| case constants.POSTGRES, constants.MYSQL, constants.DYNAMODB, constants.SQLSERVER, constants.ORACLE: | |||
| return schemaFromSource.schemaFromDatabase(migrationProjectId, sourceProfile, targetProfile, &GetInfoImpl{}, &common.ProcessSchemaImpl{}) | |||
| case constants.PGDUMP, constants.MYSQLDUMP: | |||
| return schemaFromSource.SchemaFromDump(sourceProfile.Driver, targetProfile.Conn.Sp.Dialect, ioHelper, &ProcessDumpByDialectImpl{}) | |||
| return schemaFromSource.SchemaFromDump(targetProfile.Conn.Sp.Project, targetProfile.Conn.Sp.Instance, sourceProfile.Driver, targetProfile.Conn.Sp.Dialect, ioHelper, &ProcessDumpByDialectImpl{}) | |||
There was a problem hiding this comment.
We had discussed that you will pass the whole targetProfile here right? Instead of 3 params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.