-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a slurm workflow manager #789
base: develop
Are you sure you want to change the base?
Conversation
493648f
to
0a705d9
Compare
|
||
def generate_query_command(self, job_id): | ||
return rf""" | ||
status=$(squeue -h -o "%t" -j {job_id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how picky I am about this, but I would almost prefer the status map be in python rather than in bash.
And maybe some of the logic mapped into the base class too.
var/ramble/repos/builtin/workflow_managers/slurm/workflow_manager.py
Outdated
Show resolved
Hide resolved
super().__init__(file_path) | ||
|
||
self.runner = SlurmRunner() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also think about how to allow this modifier to have a default mpi_command
(that could still be overridden)
Example usage: ```yaml ramble: variants: workflow_manager: slurm variables: mpi_command: mpirun -n {n_ranks} -hostfile hostfile processes_per_node: 1 applications: hostname: workloads: local: experiments: test: variables: n_nodes: 1 ``` ``` # The batch_submit is defined by the workflow object ramble on # Executors for query and cancel are available ramble on --executor "{query_job}" ramble on --executor "{cancel_job}" ```
Example usage: