-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gemma on Dataflow example to pass max_length as arg #11897
Open
jrmccluskey
wants to merge
6
commits into
GoogleCloudPlatform:main
Choose a base branch
from
jrmccluskey:max_len
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Jun 24, 2024
Got a clean run using this version of the code on a different GCP project since the test runs here have been hitting compute quotas |
We got this warning, although not the source of the errors:
|
davidcavazos
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Oct 8, 2024
Looks like tests failed due to timeout. |
davidcavazos
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 2, 2024
kokoro-team
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Dec 2, 2024
This might require updating to the latest branch, secrets have changed and it might be using an older image version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passes the max_length parameter to Gemma's
generate()
call through inference_args rather than having a hard-coded option.Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)