Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemma on Dataflow example to pass max_length as arg #11897

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jrmccluskey
Copy link
Contributor

Description

Passes the max_length parameter to Gemma's generate() call through inference_args rather than having a hard-coded option.

Checklist

@jrmccluskey jrmccluskey requested review from a team as code owners June 24, 2024 15:02
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 24, 2024
@jrmccluskey
Copy link
Contributor Author

Got a clean run using this version of the code on a different GCP project since the test runs here have been hitting compute quotas

@davidcavazos
Copy link
Contributor

We got this warning, although not the source of the errors:

/workspace/dataflow/gemma/custom_model_gemma.py:143: BeamDeprecationWarning: WriteStringsToPubSub is deprecated since 2.7.0. Use WriteToPubSub instead.

@davidcavazos davidcavazos added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@davidcavazos
Copy link
Contributor

======================== 1 failed in 3607.33s (1:00:07) ========================
nox > Command pytest --junitxml=sponge_log.xml failed with exit code 1
nox > Session py-3.11 failed.
make: *** [Makefile:40: test] Error 1


err: signal: killed

Looks like tests failed due to timeout.

@davidcavazos davidcavazos added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 2, 2024
@davidcavazos
Copy link
Contributor

This might require updating to the latest branch, secrets have changed and it might be using an older image version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants