-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs. #7405
base: main
Are you sure you want to change the base?
Conversation
…to match with corresponding REST API specs.
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 20 insertions(+), 20 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeSharedVpc_basic|TestAccIAM2AccessBoundaryPolicy|TestAccKmsKeyRing_basic|TestAccComputeResourceUsageExportBucket|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccLoggingBucketConfigProject_cmekSettings|TestAccKmsKeyRingIamPolicy|TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccKmsKeyRingIamPolicy_withCondition|TestAccProject_deleteDefaultNetwork|TestAccKmsKeyRingIamMember_withCondition|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccDialogflowIntent_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccKmsKeyRingIamBinding|TestAccDialogflowIntent_update|TestAccKmsCryptoKeyVersion_patch|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccDialogflowFulfillment_update|TestAccKmsCryptoKeyVersion_basic|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccDialogflowEntityType_update|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKeyIamMember|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamBinding|TestAccDialogflowAgent_update|TestAccComputeProjectMetadata_basic|TestAccComputeProjectMetadata_modify_1|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeForwardingRule_update|TestAccBinaryAuthorizationPolicy_update|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBinaryAuthorizationPolicy_full|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccBinaryAuthorizationPolicy_basic|TestAccAppEngineStandardAppVersion_update|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeSyncAuthorization_update|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccLoggingProjectCmekSettings_basic|TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved conflicts from #7463 |
This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 11 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 12 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 13 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 14 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 15 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 16 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 17 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 18 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 42 Click here to see the affected service packages
Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 11 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 12 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 13 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 14 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 15 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 16 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 17 weeks. Is it ready to merge? Use the label |
docs: Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs.
There were incorrect descriptions for some arguments. Updated them to match with the published API specification.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)