Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible: GDNS Managed Zone and fixing Ansible errors #6

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

rambleraptor
Copy link
Contributor

This creates the DNS Managed Zone resource.

It also fixes the following differences with the handwritten module

  • Missing fetch_resource
  • Missing : on a couple functions
  • pep8 lint issues

Change-Id: I617b320d7d4324c68721f843564c4d70d204a6f7
Copy link
Contributor

@nelsonjr nelsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambleraptor rambleraptor merged commit a31f633 into GoogleCloudPlatform:master Jan 18, 2018
@rambleraptor rambleraptor deleted the ansible-dns-2 branch January 18, 2018 23:26
chrisst pushed a commit to chrisst/magic-modules that referenced this pull request Oct 26, 2018
…-bucket-lifecycle

Add provider/google/google_storage_bucket lifecycle interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants