Move to opening PRs against the real terraform repository. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
approved these changes
Mar 26, 2018
| @@ -123,16 +122,24 @@ jobs: | |||
| resource: magic-modules-new-prs | |||
| passed: [mm-generate] | |||
| version: every | |||
| # TODO(ndmckinley): This will unconditionally attempt to create a PR - before | |||
There was a problem hiding this comment.
Does this mean that if a change is made that only affects chef, that an empty PR would be opened against TF?
There was a problem hiding this comment.
For now! It'll definitely have to be fixed before we turn on trigger: true. I have a plan for it in the design doc, iirc - won't be hard, just isn't done yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concourse-github-pr-resource[all]
No changes.