Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible DNS #2

Closed

Conversation

rambleraptor
Copy link
Contributor

No description provided.

Change-Id: I39d2db82cb92e2c450e42e6df73da5553ec109af
Copy link
Contributor

@nelsonjr nelsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline let's split this change into 2 phases:

  • Add support to generate Ansible artifacts
  • Generate DNS support for Ansible

Also add more information on the commit messages.

@nelsonjr
Copy link
Contributor

Also tease apart unrelated changes, such as NONE removal. As matter of policy 1 commit = 1 feature/bug/cleanup.

@rambleraptor
Copy link
Contributor Author

Removing PR.

@rambleraptor rambleraptor deleted the ansible-dns-3 branch January 18, 2018 19:34
nat-henderson added a commit that referenced this pull request Mar 8, 2018
Also changes the names of intermediate generation steps to make more
sense, and generally shrinks overall size of operations.
nat-henderson added a commit that referenced this pull request Sep 21, 2018
# This is the 1st commit message:

Generate Filestore in Terraform in Magic Modules.

Two significant magic modules changes here:

* This change adds the new parameter setting 'url_param_only',
which suppresses the value in the body of HTTP requests.  This is
necessary in new-style products, where /location/ is used instead
of zone or region.

* This change fixes an issue with 'ignore_read', which previously
only worked on top-level fields.  With this change, nested fields
also are not set on read if marked 'ignore_read'.

Both of these are implemented in terraform only.

# This is the commit message #2:

remove YAGNI problem / make rubocop happy.
KaylaNguyen added a commit to KaylaNguyen/magic-modules that referenced this pull request Jul 1, 2020
mirobertod pushed a commit to mirobertod/magic-modules that referenced this pull request May 31, 2022
c2thorn added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants