-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible DNS #2
Closed
rambleraptor
wants to merge
1
commit into
GoogleCloudPlatform:master
from
rambleraptor:ansible-dns-3
Closed
Ansible DNS #2
rambleraptor
wants to merge
1
commit into
GoogleCloudPlatform:master
from
rambleraptor:ansible-dns-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I39d2db82cb92e2c450e42e6df73da5553ec109af
nelsonjr
reviewed
Jan 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline let's split this change into 2 phases:
- Add support to generate Ansible artifacts
- Generate DNS support for Ansible
Also add more information on the commit messages.
Also tease apart unrelated changes, such as NONE removal. As matter of policy 1 commit = 1 feature/bug/cleanup. |
Removing PR. |
nat-henderson
added a commit
that referenced
this pull request
Mar 8, 2018
Also changes the names of intermediate generation steps to make more sense, and generally shrinks overall size of operations.
nat-henderson
added a commit
that referenced
this pull request
Sep 21, 2018
# This is the 1st commit message: Generate Filestore in Terraform in Magic Modules. Two significant magic modules changes here: * This change adds the new parameter setting 'url_param_only', which suppresses the value in the body of HTTP requests. This is necessary in new-style products, where /location/ is used instead of zone or region. * This change fixes an issue with 'ignore_read', which previously only worked on top-level fields. With this change, nested fields also are not set on read if marked 'ignore_read'. Both of these are implemented in terraform only. # This is the commit message #2: remove YAGNI problem / make rubocop happy.
nat-henderson
added a commit
that referenced
this pull request
Jan 3, 2019
modular-magician
pushed a commit
that referenced
this pull request
Jan 3, 2019
modular-magician
pushed a commit
that referenced
this pull request
Jan 3, 2019
KaylaNguyen
added a commit
to KaylaNguyen/magic-modules
that referenced
this pull request
Jul 1, 2020
mirobertod
pushed a commit
to mirobertod/magic-modules
that referenced
this pull request
May 31, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.