Be smarter about choosing branch names - pick readable ones. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-henderson
force-pushed
the
better-branch-names
branch
from
8d09669 to
90cd010
Compare
nat-henderson
force-pushed
the
better-branch-names
branch
2 times, most recently
from
e2592dc to
890b8c3
Compare
nat-henderson
force-pushed
the
better-branch-names
branch
from
890b8c3 to
d4ccd79
Compare
rambleraptor
approved these changes
Mar 12, 2018
mirobertod
pushed a commit
to mirobertod/magic-modules
that referenced
this pull request
May 31, 2022
feat: Added protocol variable to support MySQL/MariaDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old branch names were commit hashes - those are reasonably unique, but yesterday I realized that we actually already have a great uniquifier in here already, because we're running this on GitHub PRs. 🤦♂️
This also solves the problem of pushing updates to a PR - now we'll update an existing branch rather than writing a new one. It makes the downstream PRs easier to read, because now the branch says that they're codegen, and refers to a PR number... it's a lot better.