Use the CI which lives in this repo instead of the old one. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we try one approach first, and if that approach is painful, we can try the other one. I would go first with the ci/ in master branch because it is simpler and you have this atomicity property. Hopefully, the ci/ code won't change much after a few weeks 🤞 and it won't cause much pain. |
|
That idea works for me. I'll make that change. |
nat-henderson
force-pushed
the
switch-tracking
branch
from
6fa0072 to
efd0c11
Compare
Note: this tracks the PR branch, meaning that changes to .ci are reflected *immediately*... unless they're to ci.yml, which is set manually on the jumpbox.
nat-henderson
force-pushed
the
switch-tracking
branch
from
efd0c11 to
9322d34
Compare
|
There we go - this changes it to track the PR branch. |
rosbo
approved these changes
Mar 9, 2018
mirobertod
pushed a commit
to mirobertod/magic-modules
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your opinion needed! This is only maybe the best way to do this!
This PR changes the definition of the
cirepo to be this repository, except tracking thestable-citag instead ofmaster. The reason I'm doing this, and not just usingmaster(which is present in most of these tasks already), is because of development advantages of partially decoupling CI from the code under test.There is a good argument to be made in the other direction, though! The advantages of doing it this way are that there's stability - PRs which are based off old code will get the advantages of updates we made to the CI system, and once we push a change to
stable-ci, we can be certain that it's evaluated for all following PRs. The advantage of doing it the other way are atomicity - you can send one PR which tweaks generation for Ansible and change the CI to accommodate it in a single step, and they can be deployed and rolled back independently.Please tell me what you think! I'm asking for your opinions specifically because you have worked with Concourse before - Vincent on this repo before me, and Alex on Ansible just now. :)