Adds a PR template to magic-modules. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
approved these changes
Mar 15, 2018
|
I've been thinking about it, and I regret writing that |
|
Okay @rambleraptor, PTAL - this is a better way to do it. |
rambleraptor
approved these changes
Mar 24, 2018
mirobertod
pushed a commit
to mirobertod/magic-modules
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a PR template to Magic Modules so that The Magician can read what changes it thinks it's making downstream. The core piece of it is the
gawkscript in there ... Now, I thought that was the best idea at the time. It still seems right to me. But I realized while commenting it that most people probably don't know or care forawk, and if you tell me you'd rather see something else, I'd be happy to do it with python instead. Or tell me your favorite language for string manipulation and I'll do it there!