Fix error drop column with reserved word #12626
Conversation
Signed-off-by: kataoka-ayumu <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
modular-magician
added
the
awaiting-approval
| droppedColumnsString := strings.Join(droppedColumns, ", DROP COLUMN ") | ||
| backquotedDroppedColumns := []string{} | ||
| for _, column := range droppedColumns { | ||
| backquotedDroppedColumns = append(backquotedDroppedColumns, fmt.Sprintf("`%s`", column)) | ||
| } | ||
| droppedColumnsString := strings.Join(backquotedDroppedColumns, ", DROP COLUMN ") |
There was a problem hiding this comment.
If droppedColumns = []string("column1", "column2") ,
backquotedDroppedColumns = []string("`column1`", "`column2`")
droppedColumnsString = "`column1`, DROP COLUMN `column2`"
dropColumnsDDL = "ALTER TABLE <table_id> DROP Column `column1`, DROP COLUMN `column2`"
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Fix: hashicorp/terraform-provider-google#20750
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.