Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor documentation for resource metadata #12620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Dec 19, 2024

Adds some light documentation for working with these metadata files (ie. *_meta.yaml).

Note that most regular mmv1 resources will not have to do anything additional, and we will be performing regular checks to correct/add files as needed.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@roaks3 roaks3 requested review from a team and ScottSuarez and removed request for a team December 19, 2024 18:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have more context on this change or a doc I can reference?


# MMv1 metadata reference

This page documents all properties for metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add information about when this file is needed? You mention in you PR that most resources would be unaffected. When would they be affected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added some clarification. The file is autogenerated for MMv1, so it is only really needed for handwritten resources (which is why that guide was updated as well).

@roaks3
Copy link
Contributor Author

roaks3 commented Dec 19, 2024

Shared doc link with you internally

@roaks3 roaks3 requested a review from ScottSuarez December 19, 2024 22:31
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Contributor

I have some concerns about the overhead here. commented on the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants