Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migrate google_compute_firewall_policy_association resource from DCL to MMv1" #12614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melinath
Copy link
Member

@melinath melinath commented Dec 19, 2024

Reverts #12466. It's missing a few elements needed for safe DCL -> MMv1 migration.

compute: `google_compute_firewall_policy_association` now uses MMv1 engine instead of DCL. (revert)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 135 insertions(+), 277 deletions(-))
google-beta provider: Diff ( 6 files changed, 135 insertions(+), 277 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 94 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1076
Passed tests: 1002
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyAssociation_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants