Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes for keyhandle data source #12613

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nb-goog
Copy link
Contributor

@nb-goog nb-goog commented Dec 19, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

kmskeyhandle: improved documentation for keyhandle datasource

@github-actions github-actions bot requested a review from hao-nan-li December 19, 2024 14:31
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants