Remove 'diffSuppressSourceRanges' function from Firewall

[doron8]

It seems that 'diffSuppressSourceRanges' function purpose is to suppress "0.0.0.0/0" to "" changes in source ranges field.

However:

• 0.0.0.0/0 is not equivalent to "", as "" also include all IPv6 addresses.
• 0.0.0.0/0 also means that source ranges field is specified, which is required in some situations (e.g. there is no other source specified).

The current function also causes an issue in which removing a source range is not applied - added tests to address such situations.

Remove 'diffSuppressSourceRanges' function from Firewall

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 62 insertions(+), 39 deletions(-))
google-beta provider: Diff ( 2 files changed, 62 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field source_ranges lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1077
Passed tests: 1003
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewall_localRanges

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewall_localRanges [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test