Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppressing Project id vs project number diff in forwardingRule.target #12606

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

himanikh
Copy link
Contributor

@himanikh himanikh commented Dec 18, 2024

suppressing Project id vs project number diff in forwardingRule.target

This is to unblock
https://github.com/GoogleCloudPlatform/magic-modules/pull/12548/files

The chan

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from trodge December 18, 2024 21:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 124 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4372
Passed tests: 3947
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4372
Passed tests: 3947
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4372
Passed tests: 3947
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4372
Passed tests: 3947
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 85 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 85 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4372
Passed tests: 3806
Skipped tests: 421
Affected tests: 145

Click here to see the affected service packages

All service packages are affected

Action taken

Found 145 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbBackup_alloydbBackupBasicTestExample
  • TestAccAlloydbBackup_alloydbBackupFullExample
  • TestAccAlloydbBackup_createBackupWithMandatoryFields
  • TestAccAlloydbBackup_update
  • TestAccAlloydbBackup_usingCMEK
  • TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight
  • TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser
  • TestAccAlloydbCluster_alloydbClusterBasicExample
  • TestAccAlloydbCluster_alloydbClusterFullExample
  • TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample
  • TestAccAlloydbCluster_continuousBackup_enabledByDefault
  • TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved
  • TestAccAlloydbCluster_continuousBackup_update
  • TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet
  • TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser
  • TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy
  • TestAccAlloydbCluster_mandatoryFields
  • TestAccAlloydbCluster_maximumFields
  • TestAccAlloydbCluster_restore
  • TestAccAlloydbCluster_secondaryClusterMandatoryFields
  • TestAccAlloydbCluster_secondaryClusterPromote
  • TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser
  • TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig
  • TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary
  • TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy
  • TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
  • TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate
  • TestAccAlloydbCluster_secondaryClusterUpdate
  • TestAccAlloydbCluster_secondaryClusterUsingCMEK
  • TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange
  • TestAccAlloydbCluster_standardClusterUpdate
  • TestAccAlloydbCluster_update
  • TestAccAlloydbInstance_alloydbInstanceBasicTestExample
  • TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample
  • TestAccAlloydbInstance_clientConnectionConfig
  • TestAccAlloydbInstance_createInstanceWithMandatoryFields
  • TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange
  • TestAccAlloydbInstance_createPrimaryAndReadPoolInstance
  • TestAccAlloydbInstance_networkConfig
  • TestAccAlloydbInstance_secondaryInstanceMaximumFields
  • TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag
  • TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig
  • TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig
  • TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance
  • TestAccAlloydbInstance_update
  • TestAccAlloydbUser_alloydbUserBuiltinTestExample
  • TestAccAlloydbUser_alloydbUserIamTestExample
  • TestAccAlloydbUser_updatePassword_BuiltIn
  • TestAccAlloydbUser_updateRoles_BuiltIn
  • TestAccAlloydbUser_updateRoles_IAM
  • TestAccApphubService_apphubServiceBasicExample
  • TestAccApphubService_apphubServiceFullExample
  • TestAccApphubService_serviceUpdate
  • TestAccApphubWorkload_apphubWorkloadBasicExample
  • TestAccApphubWorkload_apphubWorkloadFullExample
  • TestAccApphubWorkload_apphubWorkloadUpdate
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
  • TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
  • TestAccBigQueryTable_ResourceTags
  • TestAccBigqueryAnalyticsHubListingIamBindingGenerated
  • TestAccBigqueryAnalyticsHubListingIamMemberGenerated
  • TestAccBigqueryAnalyticsHubListingIamPolicyGenerated
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingDcrExample
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingRestrictedExample
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
  • TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated
  • TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated
  • TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated
  • TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample
  • TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyRoutineExample
  • TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyRoutineUpdate
  • TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate
  • TestAccCertificateManagerCertificateMapEntry_certificateManagerCertificateMapEntryFullExample
  • TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsAllRegionsExample
  • TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample
  • TestAccCertificateManagerCertificate_certificateManagerGoogleManagedRegionalCertificateDnsAuthExample
  • TestAccComputeBackendService_withClientTlsPolicy
  • TestAccComputeInstanceTemplate_resourceManagerTags
  • TestAccComputeInstance_resourceManagerTags
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeNetworkFirewallPolicyWithRules_update
  • TestAccComputeRegionInstanceTemplate_resourceManagerTags
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_update
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccComputeTargetHttpsProxy_certificateMap
  • TestAccComputeTargetSslProxy_update
  • TestAccContainerCluster_resourceManagerTags
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic
  • TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource
  • TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificateDNSAuthorization
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingAlloydbExample
  • TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample
  • TestAccEndpointsService_grpcNotPreComputeConfigIdByGrpcConfig
  • TestAccEndpointsService_openapiNotPreComputeConfigId
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample
  • TestAccGKEHub2Namespace_gkehubNamespaceBasicExample
  • TestAccGKEHub2Namespace_gkehubNamespaceBasicExample_update
  • TestAccInstanceGroupManager_resourceManagerTags
  • TestAccNetappBackup_NetappBackupFull_update
  • TestAccNetappBackup_netappBackupExample
  • TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update
  • TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update
  • TestAccNetappStoragePool_storagePoolCreateExample
  • TestAccNetappStoragePool_storagePoolCreateExample_update
  • TestAccNetappVolumeReplication_NetappVolumeReplicationCreateExample_update
  • TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample
  • TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample
  • TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample_update
  • TestAccNetappVolume_NetappVolumeBasicExample_update
  • TestAccNetappVolume_autoTieredNetappVolume_update
  • TestAccNetappVolume_netappVolumeBasicExample
  • TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample
  • TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules
  • TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionBasicExample
  • TestAccNetworkServicesAuthzExtension_update
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_update
  • TestAccRegionInstanceGroupManager_resourceManagerTags
  • TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
  • TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample
  • TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample
  • TestAccSecureSourceManagerRepositoryIamBindingGenerated
  • TestAccSecureSourceManagerRepositoryIamMemberGenerated
  • TestAccSecureSourceManagerRepositoryIamPolicyGenerated
  • TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryBasicExample
  • TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryInitialConfigExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointAutomaticResourcesExample_update
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexAutomaticResourcesExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexBasicExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexBasicTwoExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexDedicatedResourcesExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexDedicatedResourcesExample_update
  • TestAccWorkstationsWorkstationConfig_vmTags

Get to know how VCR tests work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants