Network profile and RDMA v1 support #12589
Conversation
…ic-modules into terraform_v1_support
…ic-modules into terraform_v1_support
…ic-modules into terraform_v1_support
Signed-off-by: alkobi-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…tenance policy uses the new versions. (GoogleCloudPlatform#12569)
…ic-modules into terraform_v1_support
…ic-modules into terraform_v1_support
…ic-modules into terraform_v1_support
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
| description: | | ||
| A full or partial URL of the network profile to apply to this network. | ||
| This field can be set only at resource creation time. For example, the | ||
| following are valid URLs: | ||
| * https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name} | ||
| * https://www.googleapis.com/compute/{api_version}/projects/{projectId}/global/networkProfiles/{network_profile_name} |
There was a problem hiding this comment.
nit: I'd recommend just v1 here, or explicitly specifying beta as a separate item. What you've written is more correct, certainly, but requires a slight amount of additional context.
| @@ -97,11 +95,9 @@ func dataSourceGoogleComputeNetworkRead(d *schema.ResourceData, meta interface{} | |||
| if err := d.Set("internal_ipv6_range", network.InternalIpv6Range); err != nil { | |||
| return fmt.Errorf("Error setting internal_ipv6_range: %s", err) | |||
| } | |||
| {{- if ne $.TargetVersionName "ga" }} | |||
| if err := d.Set("network_profile", network.NetworkProfile); err != nil { | |||
There was a problem hiding this comment.
Looks like this isn't in the client library version we're using- we could update the version in a separate PR to unblock, or drop the datasource changes to merge the rest sooner.
Tests analyticsTotal tests: 1076 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.