Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edgenetwork InterconnectAttachment resource. #12586

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

f1urps
Copy link
Contributor

@f1urps f1urps commented Dec 16, 2024

Create InterconnectAttachment resource in product edgenetwork.

Fixes hashicorp/terraform-provider-google#15665

Tests are disabled for this resource for the same reason as other resources in edgenetwork. See: #8905

Release Note Template for Downstream PRs (will be copied)

`google_edgenetwork_interconnect_attachment`

@github-actions github-actions bot requested a review from shuyama1 December 16, 2024 20:34
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 16, 2024
@modular-magician modular-magician added service/edgenetwork and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 905 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 905 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 131 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_interconnect_attachment (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_interconnect_attachment" "primary" {
  description                = # value needed
  interconnect               = # value needed
  interconnect_attachment_id = # value needed
  labels                     = # value needed
  location                   = # value needed
  mtu                        = # value needed
  network                    = # value needed
  vlan_id                    = # value needed
  zone                       = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • edgenetwork

🟢 All tests passed!

View the build log

test_env_vars:
location: 'REGION'
zone: 'ZONE'
exclude_test: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason we need to skip the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Interconnect and InterconnectAttachment resources for edgenetwork API
3 participants