-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote VPC Flow Logs Terraform API to GA #12579
Promote VPC Flow Logs Terraform API to GA #12579
Conversation
alkobi-google
commented
Dec 16, 2024
•
edited by rileykarson
Loading
edited by rileykarson
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments on initial static review- running generation.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manual test run passed (access restricted)
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>