Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote VPC Flow Logs Terraform API to GA #12579

Merged

Conversation

alkobi-google
Copy link
Contributor

@alkobi-google alkobi-google commented Dec 16, 2024

networkmanagement: promoted `google_network_management_vpc_flow_logs_config` from Beta to GA

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson December 16, 2024 13:07
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 16, 2024
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on initial static review- running generation.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1565 insertions(+), 34 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 90 deletions(-))
Open in Cloud Shell: Diff ( 16 files changed, 602 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 9
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • networkmanagement
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectBasicExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectFullExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnBasicExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnFullExample
  • TestAccNetworkManagementVpcFlowLogsConfig_updateInterconnect
  • TestAccNetworkManagementVpcFlowLogsConfig_updateVpn
    🟢 All tests passed!

View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Manual test run passed (access restricted)

@rileykarson rileykarson merged commit 5e6616b into GoogleCloudPlatform:main Dec 16, 2024
13 of 14 checks passed
cesteve pushed a commit to cesteve/magic-modules that referenced this pull request Dec 17, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants