Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote port mapping negs to ga #12551

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nme01
Copy link

@nme01 nme01 commented Dec 12, 2024

Promote the PSC Port Mapping NEG functionality from Beta to GA.

compute: promoted the PSC Port Mapping NEG functionality from Beta to GA

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 227 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 5 files changed, 5 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1073
Passed tests: 999
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPortmapExample
  • TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing is test needs to be fixed (once that is done, it would be great if you could run the 2 GA tests locally to confirm, since they aren't run in CI)

@@ -27,7 +27,6 @@ if fqdnProp != "" {
toDelete["fqdn"] = fqdnProp
}

{{- if ne $.TargetVersionName "ga" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: for this file and possibly the test file, if they no longer need beta-only behavior, you could change them to just be .go files. Of course, if you will just be adding more beta fields again soon, then it might be easier just to keep them this way.

@@ -161,7 +159,7 @@ func TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample(t *

acctest.VcrTest(t, resource.TestCase{
PreCheck: func() { acctest.AccTestPreCheck(t) },
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove the references to provider = google-beta in these configs to fix the check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants