Add tags field to Filestore Backups for TagsR2401

[aniket-gupta]

Add tags field to backup resource to allow setting tags on backup resources at creation time.
Part of b/364923942

filestore: added `tags` field to `filstore_backup` to allow setting tags for backups at creation time

The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_backup (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_backup" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreBackup_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreBackup_tags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SamanthaMathews]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-)) google-beta provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_backup (4 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_backup" "primary" {
  tags = # value needed
}

The acceptance tests are added in the file mmv1/third_party/terraform/services/filestore/resource_filestore_backup_test.go

func testAccFilestoreBackupTags(instanceName string, backupName string, tags map[string]string) string {

	r := fmt.Sprintf(`
	resource "google_filestore_instance" "instance" {
          name     = "%s"
          location = "us-central1-b"
          tier     = "BASIC_HDD"
            file_shares {
              capacity_gb = 1024
              name        = "share1"
            }
            networks {
              network      = "default"
              modes        = ["MODE_IPV4"]
              connect_mode = "DIRECT_PEERING"
            }
        }
        resource "google_filestore_backup" "backup" {
          name              = "%s"
          location          = "us-central1"
          description       = "This is a filestore backup for the test instance"
          source_instance   = google_filestore_instance.instance.id
          source_file_share = "share1"
          labels = {
            "files":"label1",
            "other-label": "label2"
          }
	  tags = {`, instanceName, backupName)

	l := ""
	for key, value := range tags {
		l += fmt.Sprintf("%q = %q\n", key, value)
	}

	l += fmt.Sprintf("}\n}")
	return r + l
}

Please find the acceptance test screenshot https://screenshot.googleplex.com/temtbcpEWtEWcit

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_backup (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_backup" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreBackup_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreBackup_tags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 105 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_backup (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_backup" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreBackup_tags

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccFilestoreBackup_tags [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[roaks3]

LGTM, I think the prior test run failed because the bootstrapped resources needed to be created