-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ApigeeEnvironment update response type. #12415
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 51 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
This PR fixes the
ApigeeEnvironment
update response type according to the public documentation.The issue is related to the fact that after requesting the update to
ApigeeEnvironment
here, the provider expects that the response will contain the Operation details to then wait for theOperation
to complete here. Unlike Environment create request, which returnsOperation
, the update response has a type Environment according to the public docs, meaning that the ApigeeOperationWaitTime tries to process theEnvironment
asOperation
.The Operation has a
name
key that is used to track its progress. However, theEnvironment
also has aname
key that contains the name of theEnvironment
. That's why the users may see a weirdapigee.googleapis.com/v1/<env-name>?alt=json
GET
requests that result in404 Not Found
while doing an update to their environments. In that case, theApigeeOperationWaitTime
interprets<env-name>
as the operation name.Here's a fix to a similar issue for the
ApigeeOrganization
: #12413Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.