Expand Terraform for Developer Connect #12391

ihnarayanan · 2024-11-21T21:40:53Z

fixes hashicorp/terraform-provider-google#20737

developerconnect: added `crypto_key_config`, `github_enterprise_config`, `gitlab_config` , and `gitlab_enterprise_config` fields to `google_developer_connect_connection` resource (beta)

`google_developer_connect_git_repository_link` (ga)

`google_developer_connect_connection` (ga)

…eloper Connect. Promote to GA

modular-magician · 2024-11-21T21:51:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4065 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2109 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 941 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-21T21:54:08Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-21T21:54:46Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:01:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4128 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2172 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T17:04:10Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-25T17:04:47Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:42:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4128 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2172 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T17:45:09Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-25T17:45:37Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T21:21:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4143 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2187 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T21:23:32Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-25T21:24:01Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-03T16:24:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4077 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 6 files changed, 2074 insertions(+), 218 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 960 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-12-03T16:27:20Z

Tests analytics

Total tests: 9
Passed tests: 2
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-03T16:28:26Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-05T17:11:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4085 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 6 files changed, 2082 insertions(+), 218 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 964 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-12-05T17:14:17Z

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-05T17:15:10Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-12-09T02:05:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4383 insertions(+), 79 deletions(-))
google-beta provider: Diff ( 7 files changed, 2312 insertions(+), 226 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
  labels = # value needed
}

modular-magician · 2024-12-09T02:08:00Z

Tests analytics

Total tests: 12
Passed tests: 8
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-09T02:09:03Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-12-16T22:37:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4494 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 2426 insertions(+), 230 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 463 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field etag became Computed only on google_developer_connect_connection - reference
Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2024-12-16T22:40:17Z

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

modular-magician · 2024-12-16T23:16:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4514 insertions(+), 79 deletions(-))
google-beta provider: Diff ( 7 files changed, 2444 insertions(+), 227 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-16T23:18:37Z

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

modular-magician · 2024-12-17T00:25:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4514 insertions(+), 79 deletions(-))
google-beta provider: Diff ( 7 files changed, 2444 insertions(+), 227 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-17T00:27:57Z

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

modular-magician · 2024-12-17T01:13:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4772 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 2702 insertions(+), 228 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-17T01:15:48Z

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

github-actions · 2024-12-17T21:51:29Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/products/developerconnect/Connection.yaml

zli82016 · 2024-12-18T16:25:28Z

Is a Github issue for this PR? Thanks.

ihnarayanan · 2024-12-18T17:01:56Z

hashicorp/terraform-provider-google#20737

zli82016 · 2024-12-18T17:23:55Z

Thanks, I added the Github issue to the description section of this PR

zli82016 · 2024-12-18T17:25:19Z

mmv1/products/developerconnect/GitRepositoryLink.yaml

-base_url: 'projects/{{project}}/locations/{{location}}/connections/{{parent_connection}}/gitRepositoryLinks'
-self_link: 'projects/{{project}}/locations/{{location}}/connections/{{parent_connection}}/gitRepositoryLinks/{{git_repository_link_id}}'
-create_url: 'projects/{{project}}/locations/{{location}}/connections/{{parent_connection}}/gitRepositoryLinks?gitRepositoryLinkId={{git_repository_link_id}}'
+name: GitRepositoryLink


Do you mind moving the changes of this file to a separate PR? This PR is too large and difficult to review. It is easy to missing something during the code review.

Removed all changes and associated test files. Kept file in PR to promote to GA so as to not break the provider.

modular-magician · 2024-12-18T18:22:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4312 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 6 files changed, 2199 insertions(+), 170 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 20 files changed, 586 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-18T18:25:20Z

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T18:26:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4312 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 6 files changed, 2199 insertions(+), 170 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 20 files changed, 586 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-18T18:29:10Z

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

zli82016 · 2024-12-19T19:25:05Z

Can you resolve the conflicts? Thanks.

zli82016 · 2024-12-19T21:07:10Z

...party/terraform/services/developerconnect/resource_developer_connect_connection_test.go.tmpl

+    host_uri = "https://ghe.proctor-staging-test.com"
+    app_id = 864434
+    private_key_secret_version = "projects/devconnect-terraform-creds/secrets/tf-test-ghe-do-not-change-ghe-private-key-f522d2/versions/latest"
+    webhook_secret_secret_version = "projects/devconnect-terraform-creds/secrets/tf-test-ghe-do-not-change-ghe-webhook-secret-3c806f/versions/latest"


Is it possible to update these fields with new values to test if the updating is working or not?

zli82016 · 2024-12-19T21:09:15Z

...party/terraform/services/developerconnect/resource_developer_connect_connection_test.go.tmpl

+    }
+
+    authorizer_credential {
+      user_token_secret_version = "projects/devconnect-terraform-creds/secrets/gitlab-auth-cred/versions/latest"


Is it possible to update this field with a new value to test if the updating is working or not?

zli82016 · 2024-12-19T21:11:10Z

...party/terraform/services/developerconnect/resource_developer_connect_connection_test.go.tmpl

+    }
+
+    authorizer_credential {
+      user_token_secret_version = "projects/devconnect-terraform-creds/secrets/gitlab-enterprise-auth-cred/versions/latest"


Is it possible to update this field with a new value to test if the updating is working or not?

zli82016 · 2024-12-19T21:11:14Z

...party/terraform/services/developerconnect/resource_developer_connect_connection_test.go.tmpl

+  }
+
+  gitlab_enterprise_config {
+    host_uri = "https://gle-us-central1.gcb-test.com"


Is it possible to update this field with a new value to test if the updating is working or not?

zli82016 · 2024-12-19T21:12:35Z

mmv1/products/developerconnect/Connection.yaml

+      - name: appId
+        type: String
+        description: Optional. ID of the GitHub App created from the manifest.
+      - name: webhookSecretSecretVersion


Can you confirm if this field is immutable or not? immutable: true is added into other webhookSecretSecretVersion fields.

Add terraform GitHub Enterprise, GitLab, and GitLab Enterprise to Dev…

c95c0f8

…eloper Connect. Promote to GA

modular-magician added the service/developerconnect label Nov 21, 2024

Add fix for Gitlab connection tests

42d47c5

Add fix for Gitlab Connection test

a9ef9bc

Add fix for Gitlab Connection test

61d2f7a

Add fixes for all tests

10f5d1f

Add fix for GHE Connection test

7adb99b

Add update tests

3593a30

Adding update tests

24c628c

Merge branch 'GoogleCloudPlatform:main' into dc-terraform

ae3bb93

Fix breaking changes

75b0abd

fix yaml formatting

dfe76f6

Add updated doc examples

0a6f24d

ihnarayanan marked this pull request as ready for review December 17, 2024 21:50

github-actions bot requested a review from zli82016 December 17, 2024 21:51

zli82016 reviewed Dec 18, 2024

View reviewed changes

mmv1/products/developerconnect/Connection.yaml Show resolved Hide resolved

github-actions bot requested a review from zli82016 December 18, 2024 17:02

zli82016 reviewed Dec 18, 2024

View reviewed changes

remove changes to git repository link resource

d9f5d97

github-actions bot requested a review from zli82016 December 18, 2024 18:12

remove all changes to file

5c5268f

zli82016 requested changes Dec 19, 2024

View reviewed changes

Expand Terraform for Developer Connect #12391

Are you sure you want to change the base?

Expand Terraform for Developer Connect #12391

Conversation

ihnarayanan commented Nov 21, 2024 • edited by zli82016 Loading

modular-magician commented Nov 21, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 21, 2024

Tests analytics

Action taken

modular-magician commented Nov 21, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Dec 3, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Dec 3, 2024

Tests analytics

Action taken

modular-magician commented Dec 3, 2024

modular-magician commented Dec 5, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Dec 5, 2024

Tests analytics

Action taken

modular-magician commented Dec 5, 2024

modular-magician commented Dec 9, 2024

Diff report

Missing test report

modular-magician commented Dec 9, 2024

Tests analytics

Action taken

modular-magician commented Dec 9, 2024

modular-magician commented Dec 16, 2024

Diff report

Breaking Change(s) Detected

modular-magician commented Dec 16, 2024

Tests analytics

modular-magician commented Dec 16, 2024

Diff report

Missing test report

modular-magician commented Dec 16, 2024

Tests analytics

modular-magician commented Dec 17, 2024

Diff report

Missing test report

modular-magician commented Dec 17, 2024

Tests analytics

modular-magician commented Dec 17, 2024

Diff report

Missing test report

modular-magician commented Dec 17, 2024

Tests analytics

ihnarayanan commented Nov 21, 2024 •

edited by zli82016

Loading

zli82016 Dec 18, 2024 •

edited

Loading

ihnarayanan Dec 18, 2024 •

edited

Loading