feat(HNS folders): add new resources to support HNS folders #12101

gurusai-voleti · 2024-10-23T11:30:51Z

Release Note Template for Downstream PRs (will be copied)

`google_storage_new_resource`

modular-magician · 2024-10-23T11:40:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 354 insertions(+))
google-beta provider: Diff ( 1 file changed, 354 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-10-23T11:41:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 354 insertions(+))
google-beta provider: Diff ( 1 file changed, 354 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

… into hns_folders

modular-magician · 2024-10-23T11:43:07Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2024-10-23T11:43:24Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2024-10-23T11:53:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 353 insertions(+))
google-beta provider: Diff ( 1 file changed, 353 insertions(+))

modular-magician · 2024-10-23T12:01:51Z

Tests analytics

Total tests: 109
Passed tests: 100
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-30T05:28:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 692 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 692 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

modular-magician · 2024-10-30T05:37:06Z

Tests analytics

Total tests: 111
Passed tests: 100
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-30T05:37:25Z

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-30T05:58:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 692 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 692 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

modular-magician · 2024-10-30T06:07:08Z

Tests analytics

Total tests: 111
Passed tests: 100
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-30T06:07:54Z

🟢 Tests passed during RECORDING mode:
TestAccStorageFolder_storageFolderBasicForceDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccStorageFolder_storageFolderBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-30T08:37:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 552 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 552 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_folder (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_folder" "primary" {
  bucket        = # value needed
  force_destroy = # value needed
  name          = # value needed
  recursive     = # value needed
}

modular-magician · 2024-10-30T08:46:39Z

Tests analytics

Total tests: 110
Passed tests: 101
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-30T08:55:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 552 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 552 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_folder (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_folder" "primary" {
  bucket        = # value needed
  force_destroy = # value needed
  name          = # value needed
  recursive     = # value needed
}

modular-magician · 2024-10-30T09:04:08Z

Tests analytics

Total tests: 110
Passed tests: 101
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T06:17:19Z

Tests analytics

Total tests: 115
Passed tests: 101
Skipped tests: 9
Affected tests: 5

Click here to see the affected service packages

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-18T06:18:09Z

🟢 Tests passed during RECORDING mode:
TestAccStorageFolder_FailDeleteNonEmptyFolder [Debug log]
TestAccStorageFolder_FolderForceDestroy [Debug log]
TestAccStorageFolder_storageFolderBasic [Debug log]
TestAccStorageFolder_storageFolderBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccStorageFolder_DeleteEmptyFolderWithForceDestroyDefault [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-18T08:14:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 891 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 891 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 122 insertions(+))

modular-magician · 2024-12-18T08:20:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T08:23:31Z

Tests analytics

Total tests: 115
Passed tests: 106
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T08:29:58Z

Tests analytics

Total tests: 115
Passed tests: 106
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T10:22:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T10:31:25Z

Tests analytics

Total tests: 115
Passed tests: 106
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T10:32:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 885 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T10:40:32Z

Tests analytics

Total tests: 115
Passed tests: 106
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T11:55:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 864 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 864 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T12:04:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T12:04:40Z

Tests analytics

Total tests: 115
Passed tests: 104
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-18T12:05:33Z

🟢 Tests passed during RECORDING mode:
TestAccStorageFolder_FailDeleteNonEmptyFolder [Debug log]
TestAccStorageFolder_storageFolderBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-12-18T12:06:30Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccStorageFolder_DeleteEmptyFolderWithForceDestroyDefault
TestAccStorageFolder_FailDeleteNonEmptyFolder
TestAccStorageFolder_FolderForceDestroy
TestAccStorageFolder_hnsDisabled
TestAccStorageFolder_storageFolderBasic
TestAccStorageFolder_storageFolderBasicExample
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2024-12-18T12:22:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-18T12:30:31Z

Tests analytics

Total tests: 115
Passed tests: 105
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-18T12:31:33Z

🟢 Tests passed during RECORDING mode:
TestAccStorageFolder_FailDeleteNonEmptyFolder [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

roaks3

One nit, and only open question IMO is around the "list" permission

mmv1/third_party/terraform/services/storage/resource_storage_folder_test.go

modular-magician · 2024-12-19T05:24:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 874 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 874 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

modular-magician · 2024-12-19T05:33:45Z

Tests analytics

Total tests: 115
Passed tests: 106
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

gurusai-voleti added 2 commits October 23, 2024 11:28

add hns folder logic

ad3cefc

Merge branch 'GoogleCloudPlatform:main' into hns_folders

b522bcd

modular-magician added the service/storage label Oct 23, 2024

modular-magician requested a review from kautikdk October 23, 2024 11:41

gurusai-voleti added 2 commits October 23, 2024 11:41

update

de6f2ea

Merge branch 'hns_folders' of github.com:gurusai-voleti/magic-modules…

376eead

… into hns_folders

gurusai-voleti added 5 commits October 24, 2024 05:00

add example and yaml

0646523

added test case

454d6d1

yaml changes

8eb8111

Merge branch 'GoogleCloudPlatform:main' into hns_folders

69d2966

update

ddd5b51

update

90599d5

remove example

9efe5a8

update test case

9b5195d

gurusai-voleti added 2 commits December 18, 2024 08:03

review comments

3d83330

update example

e5bd04f

gurusai-voleti added 2 commits December 18, 2024 10:11

update message

62096c9

update message

c5c00df

gurusai-voleti added 2 commits December 18, 2024 11:43

update logic

28b0e37

updated test case to tf config

ce8deca

fix

10f329f

roaks3 reviewed Dec 18, 2024

View reviewed changes

mmv1/third_party/terraform/services/storage/resource_storage_folder_test.go Outdated Show resolved Hide resolved

update test case

0043ae2

github-actions bot requested a review from roaks3 December 19, 2024 05:14

feat(HNS folders): add new resources to support HNS folders #12101

Are you sure you want to change the base?

feat(HNS folders): add new resources to support HNS folders #12101

Conversation

gurusai-voleti commented Oct 23, 2024 • edited Loading

modular-magician commented Oct 23, 2024

Diff report

Errors

modular-magician commented Oct 23, 2024

Diff report

Errors

modular-magician commented Oct 23, 2024

Tests analytics

modular-magician commented Oct 23, 2024

Tests analytics

modular-magician commented Oct 23, 2024

Diff report

modular-magician commented Oct 23, 2024

Tests analytics

modular-magician commented Oct 30, 2024

Diff report

modular-magician commented Oct 30, 2024

Tests analytics

Action taken

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

Diff report

modular-magician commented Oct 30, 2024

Tests analytics

Action taken

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

Diff report

Missing test report

modular-magician commented Oct 30, 2024

Tests analytics

modular-magician commented Oct 30, 2024

Diff report

Missing test report

modular-magician commented Oct 30, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Tests analytics

Action taken

modular-magician commented Dec 18, 2024

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Tests analytics

Action taken

modular-magician commented Dec 18, 2024

modular-magician commented Dec 18, 2024

Tests analytics

modular-magician commented Dec 18, 2024

Diff report

modular-magician commented Dec 18, 2024

Tests analytics

Action taken

modular-magician commented Dec 18, 2024

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 19, 2024

gurusai-voleti commented Oct 23, 2024 •

edited

Loading