Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertex-ai: add :UPLOAD support for model resource #12075

Open
wants to merge 14 commits into
base: vertex-ai-model-resource
Choose a base branch
from
Open

vertex-ai: add :UPLOAD support for model resource #12075

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8904529
support :COPY method
BBBmau Jan 6, 2024
56505c3
refine models copy
BBBmau Oct 31, 2024
7443668
update tmpl to go.tmpl
BBBmau Oct 31, 2024
f16163d
basic UPLOAD test works
BBBmau Oct 29, 2024
fa16d1b
Merge branch 'vertex-ai-model-resource' into vertex-ai-model-UPLOAD
BBBmau Dec 4, 2024
2fd47f0
remove commented portion since this was only in-place for subPRs
BBBmau Dec 4, 2024
65315b4
address PR changes
BBBmau Dec 4, 2024
5cbf3b9
address PR changes 2
BBBmau Dec 4, 2024
46696d8
address PR changes 3
BBBmau Dec 4, 2024
df82514
address PR changes 4
BBBmau Dec 4, 2024
6eedf63
passing upload test without description
BBBmau Dec 5, 2024
9f04d1c
add description and future fields support for UPLOAD method
BBBmau Dec 5, 2024
f20f07e
fix up some tests for both copy and upload to pass with modelName
BBBmau Dec 18, 2024
8d7d880
add update_encoder
BBBmau Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mmv1/templates/terraform/update_encoder/vertex_ai_model.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
obj["displayName"] = obj["modelName"]
delete(obj, "modelName")
delete(obj, "sourceModel")
return obj, nil
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update_encoder is necessary due to source_model being included in PATCH. The API Reference doesn't include any mention of source_model for patching existing models (such as for updating the description for a copied model)

Reference: https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.models/patch

Loading