Merge w/ downstream development branch #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6bc048e0ffb0fb49013d0a5782174377234fce15
This follows the skeleton of an App with multiple Modules, each running multiple tests. Change-Id: I3d47bcd29bed02c8c29ba4653466b8b693c00935
PR: ansible/ansible#35014 * Changing wording on autogenerated notice (and adding to rest of files) * Making code Python 2.6 compliant (no list comprehensions) * Adding documentation * Moving authentication env variable processing * Making YAML changes now that I know which YAML tests to run Change-Id: I11c9ec1e8662049cd578650860ef67e167cf376d
…supports ruby 2.5 The change has been merged and has been released in v0.51.0: rubocop/rubocop@b9953c0 Change-Id: Id050955f598a2ac4d442a18c8c472adb01f3d7b5
Change-Id: I960f730b7cb9f7278b619a6268cc83793f05174f
Change-Id: If9f1d8d16afb4316fffc7ae23f38379d896a8877
- Pinning psych to 2.1.0 - Updating comments on yaml files Change-Id: Ib6b4315f66d7b0245f1da7070da29b02581c2535
[..](...) is parsed as a link in markdown. Change-Id: I4164739472073cf9c5bd19ba0fe4e91da517ef46
Change-Id: Id5da9eee145291bc3083fced62ced984c0e756da
Change-Id: I816f534eb9b7668d2a0d88e5ffb2323280bec94d
Rakefile will automatically pick up on new providers + products and then create rake tasks to automatically run the compiler in parallel. You can run all of the products for a given provider or choose them individually run rake -T (or rake --tasks) to see all available tasks Change-Id: Iec4dda41b20b167e01f192b06e88d2e24303c415
Change-Id: I5a61ea5d4c3b81b4afca07df2756d2e9a93d401d
Change-Id: Idb35bcd95de999d6eb3a429e31c3fc640e84809b
Also fixed bug on rake compile Change-Id: I6768614957af0496d7147a66a2abdc9a640d8f7f
Change-Id: I54cc1ac403a90fd17fe21c71b50cbfe02048f04b
Change-Id: Ib5ea1674714ab4f581182a45c18bae6415a3149e
Change-Id: I0579de4abf1e9fb44282a61a96bc8b67d0c57708
Change-Id: I0c3f286a94e7c143ebb79e575a00dfc9f1ab102e
Change-Id: Ifcc7848164185c8c69e0cc6a1672287e298efc15
Change-Id: I6d37d7260283d04f7eb1d11575d722b192827c2e
Change-Id: I68ba1e775ef21f1159e8491214e2ce6d85aa32dd
--- BEGIN PRESUBMIT REPORT --- Executed @ Mon, 29 Jan 2018 11:42:34 -0800 Status Report: - [FAILED] 80 characters failed for 'codegen' - [FAILED] Tests failed for 'codegen' - [FAILED] Rubocop failed for 'codegen' - [FAILED] Tabs failed for 'codegen' - [WARNING] Skipping Ansible as it is not compatible with presubmit - [INFO] Keeping puppet/compute at local f1e4f0f - [WARNING] Not syncing master for 'build/puppet/compute' - [INFO] Keeping puppet/iam at local 1bc4d5b - [WARNING] Not syncing master for 'build/puppet/iam' - [INFO] Keeping puppet/dns at local 9713eb3 - [INFO] Keeping puppet/pubsub at local e4a416c - [WARNING] Not syncing master for 'build/puppet/pubsub' - [WARNING] Not syncing master for 'build/puppet/dns' - [INFO] Keeping puppet/container at local ae1cab4 - [WARNING] Not syncing master for 'build/puppet/container' - [INFO] Keeping puppet/spanner at local 2141336 - [INFO] Keeping puppet/resourcemanager at local 619a295 - [WARNING] Not syncing master for 'build/puppet/spanner' - [WARNING] Not syncing master for 'build/puppet/resourcemanager' - [INFO] Keeping puppet/sql at local bf5918e - [INFO] Keeping puppet/storage at local 672c72d - [WARNING] Not syncing master for 'build/puppet/sql' - [WARNING] Not syncing master for 'build/puppet/storage' - [FAILED] Executing compiler failed - [INFO] Keeping terraform/ at local 15578c5 - [WARNING] Not syncing master for 'build/terraform' - [FAILED] Executing compiler failed - [FAILED] 80 characters failed for 'build/chef/resourcemanager' - [FAILED] Executing compiler failed - [FAILED] 80 characters failed for 'build/puppet/resourcemanager' - [FAILED] 80 characters failed for 'build/puppet/iam' - [FAILED] Tests failed for 'build/puppet/auth' - [SUCCESS] Project 'build/puppet/logging' passed - [FAILED] Rubocop failed for 'build/chef/_bundle' - [FAILED] Tests failed for 'build/chef/resourcemanager' - [FAILED] Project 'build/chef/_bundle' failed (1 failures) - [SUCCESS] Project 'build/puppet/_bundle' passed - [FAILED] Rubocop failed for 'build/puppet/auth' - [FAILED] Tests failed for 'build/chef/auth' - [FAILED] Project 'build/puppet/auth' failed (2 failures) - [FAILED] Project 'build/chef/auth' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/resourcemanager' - [FAILED] Project 'build/chef/resourcemanager' failed (3 failures) - [FAILED] Executing compiler failed - [FAILED] Tests failed for 'build/puppet/iam' - [FAILED] Rubocop failed for 'build/puppet/pubsub' - [FAILED] Project 'build/puppet/pubsub' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/spanner' - [FAILED] Project 'build/puppet/spanner' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/storage' - [FAILED] Rubocop failed for 'build/puppet/dns' - [FAILED] Rubocop failed for 'build/puppet/iam' - [FAILED] Project 'build/puppet/iam' failed (3 failures) - [FAILED] Project 'build/puppet/storage' failed (1 failures) - [FAILED] Project 'build/puppet/dns' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/sql' - [FAILED] Project 'build/puppet/sql' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/container' - [FAILED] Project 'build/puppet/container' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/pubsub' - [FAILED] Project 'build/chef/pubsub' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/storage' - [FAILED] Project 'build/chef/storage' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/dns' - [FAILED] Project 'build/chef/dns' failed (1 failures) - [FAILED] Tests failed for 'build/puppet/resourcemanager' - [FAILED] Rubocop failed for 'build/puppet/resourcemanager' - [FAILED] Project 'build/puppet/resourcemanager' failed (3 failures) - [FAILED] Rubocop failed for 'build/chef/sql' - [FAILED] Project 'build/chef/sql' failed (1 failures) - [FAILED] Tests failed for 'build/puppet/compute' - [FAILED] Rubocop failed for 'build/puppet/compute' - [FAILED] Project 'build/puppet/compute' failed (2 failures) - [FAILED] Project 'codegen' failed (4 failures) Settings: [NO sync] [compile] [rubocop] [tests] [githooks] [ignorecovonly] [parallel] --- END PRESUBMIT REPORT --- --- BEGIN COVERAGE REPORT --- [-----------|XXXX ] Project 'codegen' 80.81% -> 59.85% :-( Project 'build/puppet/logging' has no coverage information :-( Project 'build/chef/_bundle' has no coverage information :-( Project 'build/puppet/_bundle' has no coverage information :-( [--------------| ] Project 'build/puppet/auth' 71.98% Project 'build/chef/auth' has no coverage information :-( [|++++ ] Project 'build/chef/resourcemanager' 21.96% :-) [|+++++++++++++++++ ] Project 'build/puppet/pubsub' 84.14% :-) [--------------| ] Project 'build/puppet/spanner' 67.56% [|+++++++++++++++++ ] Project 'build/puppet/iam' 84.29% :-) [------------------| ] Project 'build/puppet/storage' 88.11% [----------------| ] Project 'build/puppet/dns' 81.38% [---------------| ] Project 'build/puppet/sql' 75.2% [-----------------| ] Project 'build/puppet/container' 84.61% [---------------| ] Project 'build/chef/pubsub' 75.6% [------------| ] Project 'build/chef/storage' 59.99% [---------------| ] Project 'build/chef/dns' 75.05% [|++++++++++++++++++ ] Project 'build/puppet/resourcemanager' 87.82% :-) [-------------| ] Project 'build/chef/sql' 63.87% [|++++++++++++++++ ] Project 'build/puppet/compute' 79.63% :-) --- END COVERAGE REPORT --- Change-Id: Ic0bc1829e44aa7ece606191616ad0c292c26f5e7
Change-Id: I7ca4472c2b35d5638b7cedc85cbbfa60348d7bf9
* Removing autogenerated license header from several handwritten files. * Changing exception handling Change-Id: I1a12fba4dccea3e7bb998a87f544124c46db51a7
Change-Id: I1fe9b031e19c23eda306efdf3b4ddf356c51c83b
Change-Id: I82ad09805d24d05012f69b357a7c4ec16c8ed25f
Change-Id: I3758021eea48806af2893f23813e9ce2905d42d5
Change-Id: I73d0f3d1920ca6c5369315cffcbbf3dd37d7af7c
Change-Id: I3d81a94d6687bb9788016d5a915e64166503861a
Change-Id: Ib213c9c9652cab74f972c8d77379dbabe4fb89ec
* Changed Authentication to include better exception handling using module.fail_json * Added User-Agent strings * Better abstracted away sessions Change-Id: I7e6622fdcdcaf95a6bec63588c27b9bc24a1c337
ResourceRefs act through the "register" mechanism on Ansible. The output of an Ansible task (Managed Zone) is saved as a dictionary using the register command. That output is then added as input to the next task by the user. In the main function, the dictionary of returned results will be replaced by the needed value inside that dictionary. This allows us to abstract away the idea of a ResourceRef as we do in Chef/Puppet Change-Id: I55e7e770c42a3db20bede8efb26a9ce0f69ab79b
All provider.yamls have a objects field to add custom fields. This allows us to change products on a per-provider basis. Currently, this field is a Hash. This object replicates the Api of Api::HashArray allowing for backwards compatability. It will allow us to create functions that use the information inside of the objects field and allow for validation. Change-Id: I089d0c9eddf4ec6c4aec512516123ae5f6099f72
--- BEGIN PRESUBMIT REPORT --- Executed @ Tue, 30 Jan 2018 13:31:13 -0800 Status Report: - [FAILED] 80 characters failed for 'codegen' - [FAILED] Tests failed for 'codegen' - [FAILED] Tabs failed for 'codegen' - [WARNING] Skipping Ansible as it is not compatible with presubmit - [INFO] Keeping puppet/iam at local f364ca2 - [WARNING] Not syncing master for 'build/puppet/iam' - [FAILED] Executing compiler failed - [INFO] Keeping terraform/ at local 5423bc8 - [WARNING] Not syncing master for 'build/terraform' - [FAILED] Executing compiler failed - [FAILED] 80 characters failed for 'build/chef/resourcemanager' - [FAILED] Executing compiler failed - [FAILED] 80 characters failed for 'build/puppet/iam' - [FAILED] 80 characters failed for 'build/puppet/resourcemanager' - [SUCCESS] Project 'build/puppet/logging' passed - [FAILED] Tests failed for 'build/puppet/auth' - [FAILED] Rubocop failed for 'build/chef/_bundle' - [FAILED] Tests failed for 'build/chef/resourcemanager' - [FAILED] Project 'build/chef/_bundle' failed (1 failures) - [SUCCESS] Project 'build/puppet/_bundle' passed - [FAILED] Rubocop failed for 'build/puppet/auth' - [FAILED] Rubocop failed for 'build/chef/resourcemanager' - [FAILED] Tests failed for 'build/chef/auth' - [FAILED] Project 'build/puppet/auth' failed (2 failures) - [FAILED] Project 'build/chef/resourcemanager' failed (3 failures) - [FAILED] Project 'build/chef/auth' failed (1 failures) - [FAILED] Executing compiler failed - [FAILED] Tests failed for 'build/puppet/iam' - [FAILED] Rubocop failed for 'build/puppet/pubsub' - [FAILED] Project 'build/puppet/pubsub' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/spanner' - [FAILED] Project 'build/puppet/spanner' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/iam' - [FAILED] Rubocop failed for 'build/puppet/dns' - [FAILED] Rubocop failed for 'build/puppet/storage' - [FAILED] Project 'build/puppet/iam' failed (3 failures) - [FAILED] Project 'build/puppet/dns' failed (1 failures) - [FAILED] Project 'build/puppet/storage' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/sql' - [FAILED] Project 'build/puppet/sql' failed (1 failures) - [FAILED] Rubocop failed for 'build/puppet/container' - [FAILED] Project 'build/puppet/container' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/storage' - [FAILED] Project 'build/chef/storage' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/pubsub' - [FAILED] Project 'build/chef/pubsub' failed (1 failures) - [FAILED] Rubocop failed for 'build/chef/dns' - [FAILED] Project 'build/chef/dns' failed (1 failures) - [FAILED] Tests failed for 'build/puppet/resourcemanager' - [FAILED] Rubocop failed for 'build/puppet/resourcemanager' - [FAILED] Project 'build/puppet/resourcemanager' failed (3 failures) - [FAILED] Rubocop failed for 'build/chef/sql' - [FAILED] Project 'build/chef/sql' failed (1 failures) - [FAILED] Tests failed for 'build/puppet/compute' - [FAILED] Rubocop failed for 'build/puppet/compute' - [FAILED] Project 'build/puppet/compute' failed (2 failures) - [FAILED] Project 'codegen' failed (3 failures) Settings: [NO sync] [compile] [rubocop] [tests] [githooks] [ignorecovonly] [parallel] --- END PRESUBMIT REPORT --- --- BEGIN COVERAGE REPORT --- [---|XXXXXXXXXXXX ] Project 'codegen' 80.81% -> 18.92% :-( Project 'build/puppet/logging' has no coverage information :-( Project 'build/chef/_bundle' has no coverage information :-( Project 'build/puppet/_bundle' has no coverage information :-( [--------------| ] Project 'build/puppet/auth' 71.98% [|++++ ] Project 'build/chef/resourcemanager' 21.96% :-) Project 'build/chef/auth' has no coverage information :-( [|+++++++++++++++++ ] Project 'build/puppet/pubsub' 84.14% :-) [--------------| ] Project 'build/puppet/spanner' 67.56% [|+++++++++++++++++ ] Project 'build/puppet/iam' 84.29% :-) [----------------| ] Project 'build/puppet/dns' 81.38% [------------------| ] Project 'build/puppet/storage' 88.11% [---------------| ] Project 'build/puppet/sql' 75.2% [-----------------| ] Project 'build/puppet/container' 84.61% [------------| ] Project 'build/chef/storage' 59.99% [---------------| ] Project 'build/chef/pubsub' 75.6% [---------------| ] Project 'build/chef/dns' 75.05% [|++++++++++++++++++ ] Project 'build/puppet/resourcemanager' 87.82% :-) [-------------| ] Project 'build/chef/sql' 63.87% [|++++++++++++++++ ] Project 'build/puppet/compute' 79.63% :-) --- END COVERAGE REPORT --- Change-Id: I4ed0cf8740dddaea1cd58414758440448480574e
Change-Id: Ib1bd58056bc4c748cfaf8b10c741fa2b7c167c53
Change-Id: I11a58deadbe33c8dd150f1012dea49c91eaa9de0
Change-Id: If2736c10e4c03b49633412f6805147784c5765f9
This is important for DNS: Resource Record Set Change-Id: Ie0e8aaffbd7d7166f0c6891371bc0933ead29a11
Change-Id: Id161192e5c500bd57901ffc27361931a66b28682
Change-Id: Ibf2880c6a0a546a4e959dd60abf8c5612cae1c02
Change-Id: I4c34434d15c963e4802fd2c815d60200e3d8ab54
Some resources on Puppet/Chef use custom code that requires access to the fetched resource. This is typically stored in the global @fetched variable. Ansible does not like global variables, so our fetched variable has to be passed around if necessary. This will be important for resources like DNS: Resource Record Sets Change-Id: Ic502b0dccfd21c0fa792d45232c511ff5306ddf3
Ansible Examples are now contained within their own objects. This allows you to create a fully formed task for use in EXAMPLES docs or integration tests. This will become useful once ResourceRefs are added in. Change-Id: Ia7c6a299693c1df22be39fdbdc7e2b694135f5db
Not all providers will want to compile all objects. This may be because of the Pull Request flow or because a provider will not implement a certain object. By adding the "skip: true" parameter to the provider.yaml file, objects can be skipped without a command line flag. Change-Id: I3997fc3a027f844d9b4a92aa0a3fa55a221349b5
nelsonjr
requested review from
danawillow,
nat-henderson,
rosbo and
rambleraptor
Change-Id: I7ad04292a02ec2d4cdbbad4ef24cf8380df111a1
rosbo
approved these changes
Feb 9, 2018
nelsonjr
force-pushed
the
catchup/20180208
branch
from
5533129 to
e05871b
Compare
nat-henderson
approved these changes
Feb 9, 2018
danawillow
approved these changes
Feb 9, 2018
chrisst
pushed a commit
to chrisst/magic-modules
that referenced
this pull request
Oct 26, 2018
* Add ability to import `google_sql_database` * Update from code review * Ensure split id length and report error otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.