-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deletion_protection field to Redis Instance #11735
base: main
Are you sure you want to change the base?
Add deletion_protection field to Redis Instance #11735
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Discussing with @SamanthaMathews offline about this PR and the go rewrite migration |
2ecac0e
to
ae7b6ae
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
Add deletion_protection field to make deletion actions require an explicit intent
Part of b/367733375
Part of hashicorp/terraform-provider-google#18854
Release Note Template for Downstream PRs (will be copied)