Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion_protection field to Redis Instance #11735

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

Add deletion_protection field to make deletion actions require an explicit intent
Part of b/367733375

Part of hashicorp/terraform-provider-google#18854

Release Note Template for Downstream PRs (will be copied)


Redis: added `deletion_protection` field to `redis_instance` to make deleting them require an explicit intent. `redis_instance` resources now cannot be destroyed unless `deletion_protection = false` is set for the resource.

Copy link

google-cla bot commented Sep 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 17, 2024
@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

@zli82016 zli82016 force-pushed the deletion_protection-Redis branch from 2ecac0e to ae7b6ae Compare September 27, 2024 20:57
@modular-magician modular-magician added service/redis-instance and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 134 insertions(+), 145 deletions(-))
google-beta provider: Diff ( 5 files changed, 134 insertions(+), 145 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccRedisInstance_deletionprotection
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/redis-instance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants