Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion_protection field to Metastore Federation #11690

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

Add deletion_protection field to make deletion actions require an explicit intent
Part of b/366209903

Part of hashicorp/terraform-provider-google#18854

Release Note Template for Downstream PRs (will be copied)

Metastore: added `deletion_protection` field to `dataproc_metastore_service` to make deleting them require an explicit intent. `google_active_directory_domain` resources now cannot be destroyed unless `deletion_protection = false` is set for the resource.

Copy link

google-cla bot commented Sep 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 12, 2024
@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

@c2thorn c2thorn force-pushed the deletion_protection-metastore-federation branch from 04cf9e9 to 3733d7b Compare September 27, 2024 19:32
migration changes (+6 squashed commits) Squashed commits: [e05eb31] Update resource_dataproc_metastore_federation_test.go [991ee05] migration changes [8465afe] deletion_protection-metastore-federation [53024d4] deletion_protection-metastore-federation [788652d] deletion_protection-metastore-federation [b0423e3] commit deletion_protection-metastore-federation
@c2thorn c2thorn force-pushed the deletion_protection-metastore-federation branch from 3733d7b to f73a14a Compare September 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants