Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags field to Datafusion Instances for TagsR2401 #11681

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/337048265

Release Note Template for Downstream PRs (will be copied)

datafusion: added `tags` field to `datafusion_instance` to allow setting tags for instances at creation time

Copy link

google-cla bot commented Sep 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 11, 2024
@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

commit terraform-datafusion-instance-tags
commit terraform-datafusion-instance-tags
@c2thorn c2thorn force-pushed the terraform-datafusion-instance-tags branch from 06849d1 to 1bea6dd Compare September 26, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants