-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags field to Alloydb Backup for TagsR2401 #11629
base: main
Are you sure you want to change the base?
Add tags field to Alloydb Backup for TagsR2401 #11629
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_backup" "primary" {
tags = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Samantha! Thanks for contributing, three things:
- The code is failing to compile. Here is the error from the logs
# github.com/hashicorp/terraform-provider-google-beta/google-beta/services/alloydb
google-beta/services/alloydb/resource_alloydb_backup_test.go:326:2: expected declaration, found '}'
- I don't see these fields documented on the API docs. Is that correct?
https://cloud.google.com/alloydb/docs/reference/rest/v1/projects.locations.backups
- I don't appear to have access to the bug linked in the Pull Request - b/337048391
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 74 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Discussing with @SamanthaMathews offline about this PR and the go rewrite migration |
terraform-alloydb-backup-tags commit terraform-alloydbbackup-tags commit terraform-alloydb-backup-tags commit terraform-alloydb-backup-tags commit terraform-alloydb-backup-tags
8e0d369
to
50bb8fc
Compare
Add tags field to backup resource to allow setting tags on backup resources at creation time.
b/337048391
Release Note Template for Downstream PRs (will be copied)