Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags field to Alloydb Backup for TagsR2401 #11629

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

@SamanthaMathews SamanthaMathews commented Sep 4, 2024

Add tags field to backup resource to allow setting tags on backup resources at creation time.
b/337048391
Release Note Template for Downstream PRs (will be copied)

alloydb: added `tags` field to `alloydb_backup` to allow setting tags for backups at creation time

Copy link

google-cla bot commented Sep 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Sep 4, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez September 4, 2024 09:39
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 4, 2024
@SamanthaMathews SamanthaMathews marked this pull request as draft September 5, 2024 07:41
@SamanthaMathews SamanthaMathews changed the title commit terraform-alloydb-backup-tags Add tags field to Alloydb Backup for TagsR2401 Sep 6, 2024
@modular-magician modular-magician added service/alloydb and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 6, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 113 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 113 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_backup (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_backup" "primary" {
  tags = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • alloydb
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccAlloydbBackup_tags
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Samantha! Thanks for contributing, three things:

  1. The code is failing to compile. Here is the error from the logs
# github.com/hashicorp/terraform-provider-google-beta/google-beta/services/alloydb
google-beta/services/alloydb/resource_alloydb_backup_test.go:326:2: expected declaration, found '}'
  1. I don't see these fields documented on the API docs. Is that correct?

https://cloud.google.com/alloydb/docs/reference/rest/v1/projects.locations.backups

  1. I don't appear to have access to the bug linked in the Pull Request - b/337048391

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 11, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 114 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 114 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 69
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbBackup_tags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 18, 2024
@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

terraform-alloydb-backup-tags
commit terraform-alloydbbackup-tags
commit terraform-alloydb-backup-tags
commit terraform-alloydb-backup-tags
commit terraform-alloydb-backup-tags
@c2thorn c2thorn force-pushed the terraform-alloydb-backup-tags branch from 8e0d369 to 50bb8fc Compare September 26, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/alloydb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants