Add tags field to Metastore Federation for TagsR2401 #11616
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
|
Following up internally re: CLA |
SamanthaMathews
changed the title
|
Discussing with @SamanthaMathews offline about this PR and the go rewrite migration |
commit terraform-metastore-federation-tags commit terraform-metastore-federation-tags commit terraform-metastore-federation-tags
c2thorn
force-pushed
the
terraform-metastore-federation-tags
branch
from
4108c7c to
e9b70fe
Compare
There was a problem hiding this comment.
Can we move this to the existing go.tmpl file that contains other tests?
There was a problem hiding this comment.
metastore Federation doesn't have an existing test go.tmpl file
Add tags field to federation resource to allow setting tags on federation resources at creation time.
Part of b/367307391
Release Note Template for Downstream PRs (will be copied)