-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags field to Filestore Backups for TagsR2401 #11614
base: main
Are you sure you want to change the base?
Add tags field to Filestore Backups for TagsR2401 #11614
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
could you fix the changelog so that it follows what's shown in the guidelines? https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/ |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_filestore_backup" "primary" {
tags = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
} | ||
tags = {`, context) | ||
|
||
l := "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a build error due to this line:
google-beta/services/filestore/resource_filestore_backup_test.go:179:13: expected ')', found ','
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
labels = { | ||
"files":"label1", | ||
"other-label": "label2" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not hard code tags in here, use the parameter provided. Example: https://screenshot.googleplex.com/BmcLcKPfbbjhbji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
t.Parallel() | ||
|
||
org := envvar.GetTestOrgFromEnv(t) | ||
instName := fmt.Sprintf("tf-fs-inst-%d", acctest.RandInt(t)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: instanceName backupName instead of instName bkupName in all usages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Discussing with @SamanthaMathews offline about this PR and the go rewrite migration |
deletion_protection-backup-tags commit terraform-filestore-backup-tags commit terraform-filestore-backup-tags commit terraform-filestore-backup-tags commit terraform-filestore-backup-tags commit terraform-filestore-backup-tag
fa226fb
to
2070e67
Compare
Converted, backed up at https://github.com/NickElliot/magic-modules/tree/terraform-filestore-backup-tags-11614-backup |
Add tags field to backup resource to allow setting tags on backup resources at creation time.
Part of b/364923942
release-note:none