Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags field to Alloydb Cluster for TagsR2401 #11591

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

@SamanthaMathews SamanthaMathews commented Aug 30, 2024

Add tags field to cluster resource to allow setting tags on cluster resources at creation time.
b/365030846

Release Note Template for Downstream PRs (will be copied)

alloydb: added `tags` field to `alloydb_cluster` to allow setting tags for clusters at creation time

Copy link

google-cla bot commented Aug 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 August 30, 2024 15:21
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 30, 2024
Copy link

github-actions bot commented Sep 4, 2024

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SamanthaMathews SamanthaMathews marked this pull request as draft September 5, 2024 07:40
@SamanthaMathews SamanthaMathews changed the title commit terraform-alloydbcluster-tags Add tags field to Alloydb Cluster for TagsR2401 Sep 6, 2024
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamanthaMathews it looks like this is still in draft mode, so just let me know when you are ready for a review

@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

@c2thorn c2thorn force-pushed the terraform-alloydbcluster-tags branch from e4e7839 to 3826ed1 Compare September 30, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants