Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TestAccContainerCluster_withProviderDefaultLabels #11585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Aug 29, 2024

PR fixes hashicorp/terraform-provider-google#19305

Nightly tests show that terraform labels have changed from 2 -> 3, this could be due to recent addition to terraform labels.

Nightly Tests: https://hashicorp.teamcity.com/test/49563372925432536?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_NIGHTLYTESTS&branch=%3Cdefault%3E&expandTestHistoryChartSection=true

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 203
Passed tests: 190
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@melinath
Copy link
Member

@BBBmau looks like this fixes a 100% test failure - are you still working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainerCluster_withProviderDefaultLabels
3 participants