Add tags field to Memcache Instance for TagsR2401

[SamanthaMathews]

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/367727387

Release Note Template for Downstream PRs (will be copied)

Memcache: added `tags` field to `memcache_instance` to allow setting tags for instances at creation time

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[SarahFrench]

@SamanthaMathews Hi, thanks for opening a PR! Could you please sign the CLA and I can get started reviewing

[c2thorn]

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memcache_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memcache_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memcache

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemcacheInstance_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccMemcacheInstance_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[abd-goog]

Please fix breaking tests

[SamanthaMathews]

@SarahFrench , could you please provide the approval for running automated test?

[SarahFrench]

I just approved the tests to run. Also, please take a look at the CLA issue!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memcache_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memcache_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memcache

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemcacheInstance_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccMemcacheInstance_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[SamanthaMathews]

Hi @SarahFrench , could you please provide the approval for running automated test again?
Also is there any way to retrigger this test without adding any random commits?

[SarahFrench]

@SamanthaMathews I believe that the tests run automatically on push for Googlers who show on their profiles that they're a member of a Google-owned GitHub org (this is how our automation detects Googlers). To trigger the tests to run without pushing a new commit you can comment /gcbrun on the PR. I'll double check internally about the Googler stuff

[SarahFrench]

Ah, I believe you need to be a member of https://github.com/googlers

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memcache_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memcache_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memcache

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemcacheInstance_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemcacheInstance_tags[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SarahFrench]

Further to what I said above

• membership of the googlers orgs needs to be public
• take a look at: go/terraform-contribution-guide#before-you-begin

[SamanthaMathews]

Thanks @SarahFrench
I am waiting for confirmation on something. Meanwhile do you mind triggering the test again?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 90 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memcache_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memcache_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memcache

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemcacheInstance_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemcacheInstance_tags[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SamanthaMathews]

@SarahFrench , the automated tests are failing. Could you please suggest a way to fix this?

[SarahFrench]

Hi @SamanthaMathews, we can mark this PR as ready for review to work through the test failure, but first please address the failing CLA check.

[SarahFrench]

@modular-magician reassign-reviewer