-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit terraform-redis-tags1 #11569
base: main
Are you sure you want to change the base?
commit terraform-redis-tags1 #11569
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@SamanthaMathews Hi, thanks for opening a PR! Could you please sign the CLA and I can get started reviewing |
@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing to dismiss automation, please see previous comment #11569 (comment)
Discussing with @SamanthaMathews offline about this PR and the go rewrite migration |
commit terraform-redis-tags1 commit terraform-redis-tags1 commit terraform-redis-tags1
a65629a
to
d00d43c
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_redis_instance" "primary" {
tags = # value needed
}
|
Tests analyticsTotal tests: 22 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@modular-magician reassign-reviewer |
Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/367402264
Release Note Template for Downstream PRs (will be copied)