Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit terraform-redis-tags1 #11569

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamanthaMathews
Copy link

@SamanthaMathews SamanthaMathews commented Aug 28, 2024

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/367402264

Release Note Template for Downstream PRs (will be copied)

redis: added `tags` field to `redis_instance` to allow setting tags for instances at creation time

Copy link

google-cla bot commented Aug 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from SarahFrench August 28, 2024 20:30
Copy link

github-actions bot commented Aug 28, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 28, 2024
@SarahFrench
Copy link
Contributor

@SamanthaMathews Hi, thanks for opening a PR! Could you please sign the CLA and I can get started reviewing

Copy link

github-actions bot commented Sep 2, 2024

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing to dismiss automation, please see previous comment #11569 (comment)

@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

commit terraform-redis-tags1
commit terraform-redis-tags1
commit terraform-redis-tags1
@c2thorn c2thorn force-pushed the terraform-redis-tags1 branch from a65629a to d00d43c Compare September 30, 2024 20:04
@modular-magician modular-magician added service/redis-instance and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Oct 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 92 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 92 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_instance (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_instance" "primary" {
  tags = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisInstance_tags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccRedisInstance_tags[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@SarahFrench
Copy link
Contributor

@modular-magician reassign-reviewer

@github-actions github-actions bot requested a review from SirGitsalot November 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants