Add tags field to Filestore Instances for TagsR2401 #11555

SamanthaMathews · 2024-08-27T12:59:59Z

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/364841739
release-note:none

filestore: added `tags` field to `filstore_instance` to allow setting tags for instances at creation time

The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

google-cla · 2024-08-27T13:00:06Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2024-08-27T13:00:42Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

NickElliot

Hi, looks like the CLA is having issues despite being a Googler. Could you verify you've completed all the steps at go/cla#troubleshoot? Thanks!

github-actions · 2024-09-04T09:41:14Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

abd-goog · 2024-09-04T12:54:30Z

mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

@@ -164,7 +193,7 @@ resource "google_filestore_instance" "instance" {
  networks {
    network           = "default"
    modes             = ["MODE_IPV4"]
-    reserved_ip_range = "172.19.31.0/29"
+    reserved_ip_range = "172.19.30.0/29"


any reason to change this?

This was autochanged.

mmv1/products/filestore/Instance.yaml

abd-goog · 2024-09-04T12:58:59Z

@SamanthaMathews please update tags in docs as well and add example usage: mmv1/third_party/terraform/website/docs/d/filestore_instance.html.markdown

You can refer to https://github.com/GoogleCloudPlatform/magic-modules/pull/11440/files#diff-5199cf2c01554435c00dd630585a1315125738f420d3a1f454430ed54aa263c4

NickElliot

still pending resolving erroneous CLA issue -- please verify if you've completed the steps I linked above

mmv1/third_party/terraform/website/docs/d/filestore_instance.html.markdown

abd-goog · 2024-09-05T11:23:19Z

mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

@@ -185,8 +211,37 @@ resource "google_filestore_instance" "instance" {
  networks {
    network           = "default"
    modes             = ["MODE_IPV4"]
-    reserved_ip_range = "172.19.31.8/29"
+    reserved_ip_range = "172.19.31.0/29"


why this change?

abd-goog · 2024-09-05T19:33:56Z

mmv1/third_party/terraform/website/docs/d/filestore_instance.html.markdown

+resource "filestore_instnace" "my_instance" {
+  name       = "My instance"
+  instance_id = "your-instance-id"
+  org_id     = "1234567"


org_id is not a supported field in filestore_instance. Please rectify.

NickElliot

Hi, looks like the CLA is having issues despite being a Googler. Could you verify you've completed all the steps at go/cla#troubleshoot? Thanks!

Please let me know if you're completed the steps, thanks!

modular-magician · 2024-09-09T21:19:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 104 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 105 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

modular-magician · 2024-09-09T21:21:14Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

filestore

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccFilestoreInstance_tags
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

abd-goog · 2024-09-12T06:01:38Z

mmv1/third_party/terraform/website/docs/d/filestore_instance.html.markdown

+To create an instance with a tag
+
+```hcl
+resource "filestore_instnace" "my_instance" {


filestore_instance

abd-goog · 2024-09-12T06:04:31Z

mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

+    modes             = ["MODE_IPV4"]
+    reserved_ip_range = "172.19.31.0/29"
+  }
+tags = {


Do not hardcode tags here please. Use the parameter to build the tags field. Similar to here: https://github.com/GoogleCloudPlatform/magic-modules/pull/11440/files

c2thorn · 2024-09-25T19:54:32Z

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

NickElliot · 2024-09-27T21:17:17Z

Converted, backup located at https://github.com/NickElliot/magic-modules/tree/terraform-filestore-tags-11555-backup

modular-magician · 2024-09-27T21:31:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 88 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

modular-magician · 2024-09-27T21:33:56Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

filestore

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccFilestoreInstance_tags
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

added import statement "github.com/hashicorp/terraform-provider-google/google/envvar"

github-actions bot requested a review from NickElliot August 27, 2024 13:00

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 27, 2024

NickElliot reviewed Aug 27, 2024

View reviewed changes

github-actions bot requested a review from NickElliot August 28, 2024 09:05

SamanthaMathews closed this Aug 29, 2024

SamanthaMathews reopened this Sep 3, 2024

abd-goog suggested changes Sep 4, 2024

View reviewed changes

NickElliot reviewed Sep 4, 2024

View reviewed changes

github-actions bot requested a review from NickElliot September 5, 2024 10:44

SamanthaMathews marked this pull request as draft September 5, 2024 11:09

abd-goog suggested changes Sep 5, 2024

View reviewed changes

SamanthaMathews changed the title ~~commit terraform-filestore-tags~~ Add tags field to Filestore Instances for TagsR2401 Sep 5, 2024

NickElliot mentioned this pull request Sep 5, 2024

Add tags field to Metstore Service for TagsR2401 #11611

Draft

abd-goog suggested changes Sep 5, 2024

View reviewed changes

NickElliot requested changes Sep 9, 2024

View reviewed changes

modular-magician added service/filestore and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 9, 2024

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 11, 2024

abd-goog reviewed Sep 12, 2024

View reviewed changes

abd-goog suggested changes Sep 12, 2024

View reviewed changes

c2thorn added the not-go-migrated label Sep 24, 2024

NickElliot force-pushed the terraform-filestore-tags branch from b1714d0 to b7606a2 Compare September 27, 2024 21:16

NickElliot removed the not-go-migrated label Sep 27, 2024

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 27, 2024

SamanthaMathews closed this Nov 21, 2024

SamanthaMathews force-pushed the terraform-filestore-tags branch from b7606a2 to a673e6a Compare November 21, 2024 15:43

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 21, 2024

resolving merge conflicts

bd9cfa9

SamanthaMathews reopened this Nov 21, 2024

SamanthaMathews added 2 commits November 25, 2024 12:03

Merge branch 'GoogleCloudPlatform:main' into terraform-filestore-tags

552d3a1

Update resource_filestore_instance_test.go

6a552ce

added import statement "github.com/hashicorp/terraform-provider-google/google/envvar"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tags field to Filestore Instances for TagsR2401 #11555

Add tags field to Filestore Instances for TagsR2401 #11555

SamanthaMathews commented Aug 27, 2024 •

edited

Loading

google-cla bot commented Aug 27, 2024

github-actions bot commented Aug 27, 2024

NickElliot left a comment •

edited

Loading

github-actions bot commented Sep 4, 2024

abd-goog Sep 4, 2024

SamanthaMathews Sep 5, 2024

abd-goog commented Sep 4, 2024

NickElliot left a comment

abd-goog Sep 5, 2024

abd-goog Sep 5, 2024

SamanthaMathews Sep 5, 2024

NickElliot left a comment

modular-magician commented Sep 9, 2024

modular-magician commented Sep 9, 2024

abd-goog Sep 12, 2024

SamanthaMathews Sep 19, 2024

abd-goog Sep 12, 2024

SamanthaMathews Sep 19, 2024

c2thorn commented Sep 25, 2024

NickElliot commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

Add tags field to Filestore Instances for TagsR2401 #11555

Are you sure you want to change the base?

Add tags field to Filestore Instances for TagsR2401 #11555

Conversation

SamanthaMathews commented Aug 27, 2024 • edited Loading

google-cla bot commented Aug 27, 2024

github-actions bot commented Aug 27, 2024

NickElliot left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abd-goog commented Sep 4, 2024

NickElliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NickElliot left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 9, 2024

Diff report

Missing test report

modular-magician commented Sep 9, 2024

Tests analytics

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c2thorn commented Sep 25, 2024

NickElliot commented Sep 27, 2024

modular-magician commented Sep 27, 2024

Diff report

Missing test report

modular-magician commented Sep 27, 2024

Tests analytics

SamanthaMathews commented Aug 27, 2024 •

edited

Loading

NickElliot left a comment •

edited

Loading