Change stateful_internal|external_ips to Set from List

[askubis]

Change stateful_internal|external_ips to Set from List. This solves all issues with ordering. All reordering code removed from IGMs.
fixes: hashicorp/terraform-provider-google#13430

Release Note Template for Downstream PRs (will be copied)

Change resource_compute_instance_group_manager and resource_compute_region_instance_gorup_manager fields: stateful_internal_ips and stateful_external_ips from TypeList to TypeSet. This fixes the ordering issues.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 33 insertions(+), 359 deletions(-))
google-beta provider: Diff ( 4 files changed, 33 insertions(+), 359 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 978
Passed tests: 904
Skipped tests: 72
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeDisk_storagePoolSpecified
• TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 33 insertions(+), 359 deletions(-))
google-beta provider: Diff ( 4 files changed, 33 insertions(+), 359 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 978
Passed tests: 906
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

• compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[shuyama1]

Would you mind also adding an entry in the upgrade guide following step 4 in https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#make-the-change-on-feature-branch-major-release-600.

Thanks!

[shuyama1]

I wonder if we want to keep this test to ensure the change from list to set works, like it also wouldn't cause permadiff for multiple stateful_internal_ip/stateful_external_ip attributes configurations.

[shuyama1]

I suspect if this flattener will work as intended. Let's bring back the test first and see it works

[askubis]

I did run the tests before removing it.

[c2thorn]

looks like this is going to miss the contribution cutoff date for 6.0 (today)

[askubis]

Would you mind also adding an entry in the upgrade guide following step 4 in https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#make-the-change-on-feature-branch-major-release-600.

Thanks!

I do not really understand how it should work for this case - there is nothing to do wrt. upgrade - for the customers the change is invisible (the same configurations that worked will continue to work).

Sorry about missing the cutoff (luckily this change is really not important), I got sick and couldn't work on it.

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shuyama1]

The 6.0 release cut is complete, so I'll move this PR to draft for now. Please feel free to reach out if you have any questions regarding this change. If you decide to proceed with this update, it will need to wait until the next major release, but I’m happy to assist along the way.