Add separate error message for not supported operation on min_cpu_platform #11289

karolgorc · 2024-07-30T09:07:29Z

Refactor how machine_type and min_cpu_platform are updated

Release Note Template for Downstream PRs (will be copied)

compute: `min_cpu_platform` and `machine_type` are no longer changed separately resolving cases where values needed to be set to `AUTOMATIC`

github-actions · 2024-07-30T09:08:07Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

melinath

Rather than clarifying the error message, would it make sense / be reasonable / solve the problem to add a section like:

if d.HasChange("min_cpu_platform") && d.HasChange("machine_type") {
  // set machine type to AUTOMATIC - it will be set to the actual value later.
}

modular-magician · 2024-07-30T18:44:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))

modular-magician · 2024-07-30T19:00:40Z

Tests analytics

Total tests: 976
Passed tests: 902
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

khajduczenia · 2024-08-02T06:59:30Z

Both parameters should be changed in one API call to Instances.Update - otherwise they need to have an in-between step of setting AUTOMATIC min_cpu_platform, which is unnecessary overhead.

if d.HasChange("min_cpu_platform") || d.HasChange("machine_type") {
  // set up Instance resource with updated configs and send an Instances.Update call
}

Btw. the general pattern of issuing individual fields modification calls to the API seems to be more driven by historic evolution of the code than through an actual benefit. It should be refactored to construct a single API call for Instances.Update.

melinath · 2024-08-02T16:07:43Z

yeah, instances.Update was not possible in the past. It would be preferable to use where possible. However, unless that would allow these fields to be updated simultaneously, it still might make sense to issue two requests - otherwise the user will have to run apply twice, which is much more inefficient.

melinath · 2024-08-02T16:08:48Z

@khajduczenia it sounds like you're saying that a single call to Update should be able to change them simultaneously, though?

karolgorc · 2024-08-06T10:59:03Z

The Instances.Update does actually work for this scenario. Now there is no requirement to set min_cpu_platform to AUTOMATIC with this refactor fixing the case from the referenced issue

modular-magician · 2024-08-06T16:23:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 insertions(+), 21 deletions(-))

modular-magician · 2024-08-06T16:37:30Z

Tests analytics

Total tests: 976
Passed tests: 889
Skipped tests: 74
Affected tests: 13

Click here to see the affected service packages

compute

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstance_diskEncryptionRestart

TestAccComputeInstance_metadataStartupScript_update

TestAccComputeInstance_minCpuPlatform

TestAccComputeInstance_stopInstanceToUpdate

TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate

Get to know how VCR tests work

modular-magician · 2024-08-06T16:41:53Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstance_diskEncryptionRestart[Error message] [Debug log]
TestAccComputeInstance_metadataStartupScript_update[Error message] [Debug log]
TestAccComputeInstance_minCpuPlatform[Error message] [Debug log]
TestAccComputeInstance_stopInstanceToUpdate[Error message] [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate[Error message] [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate[Error message] [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

melinath

These test failures look legitimate.

TestAccComputeInstance_diskEncryptionRestart: Looks like the Update call needs to include the encryption key (if one is set)

The rest are failing with errors like:

Error: googleapi: Error 400: Invalid value for field 'resource.fingerprint': '<ByteString@e19b8e1 size=8 contents="\363\377@36\357\306u">'. Fingerprint mismatch, some instance properties may have changed or you are using a different API version to get the instance resource., invalid

It looks like the StopInstance operation probably changes the fingerprint, so it would need to be re-fetched prior to calling Update.

karolgorc · 2024-08-09T10:49:09Z

Fixed the fingerprint errors by using the tpg_resource.Retry() block

The encryption keys are a bigger issue. The instances.Update() requires a rawKey to be provided when the disk is encrypted no matter the change we are making on the instance. But couldn't get this to work for now even when doing direct API calls instead of Terraform

Fails with this error even when the key is provided

{
  "error": {
    "code": 400,
    "message": "'projects/iac-poc-krakow/zones/us-central1-a/disks/disk-3' is protected with a customer supplied encryption key, but none was provided.",
    "errors": [
      {
        "message": "'projects/iac-poc-krakow/zones/us-central1-a/disks/disk-3' is protected with a customer supplied encryption key, but none was provided.",
        "domain": "global",
        "reason": "resourceIsEncryptedWithCustomerEncryptionKey"
      }
    ]
  }
}

Gonna experiment whith this for a bit, to see if it's an API bug or not

I suppose there will be a refactor on the whole ResourceComputeInstanceUpdate() function that will utilize the instances.Update more instead of using the designated API methods, because they are basically considered legacy now. So i'll enclose the update call in a separate function

melinath

Removing from review queue pending those changes

karolgorc · 2024-08-11T11:52:34Z

fixed fingerprint errors
The encryption keys issue was confirmed as an API bug. This code will work after it gets fixed.

The API doesn't read provided raw keys to decrypt the disks

Here is a correct instance payload that gets rejected in the test

"disks": [
  {
   "autoDelete": true,
   "boot": true,
   "deviceName": "persistent-disk-0",
   "diskEncryptionKey": {
    "rawKey": "SGVsbG8gZnJvbSBHb29nbGUgQ2xvdWQgUGxhdGZvcm0="
   },
   "mode": "READ_WRITE",
   "source": "projects/iac-poc-krakow/zones/us-central1-a/disks/tf-test-eadzm2j2ya"
  },
  {
   "deviceName": "persistent-disk-1",
   "diskEncryptionKey": {
    "rawKey": "Ym9vdDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI="
   },
   "mode": "READ_WRITE",
   "source": "projects/iac-poc-krakow/zones/us-central1-a/disks/tf-testd-1civ7c6zzf"
  }
 ],

Test log from this API call

-----------------------------------------------------
2024/08/11 13:19:22 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/08/11 13:19:22 [DEBUG] Retry Transport: Returning after 1 attempts
2024/08/11 13:19:22 [INFO] Instantiating GCE client for path https://compute.googleapis.com/compute/v1/
2024/08/11 13:19:22 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/08/11 13:19:22 [DEBUG] Retry Transport: request attempt 0
2024/08/11 13:19:22 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
PUT /compute/v1/projects/iac-poc-krakow/zones/us-central1-a/instances/tf-test-eadzm2j2ya?alt=json&prettyPrint=false HTTP/1.1
Host: compute.googleapis.com
User-Agent: google-api-go-client/0.5 Terraform/1.9.2 (+https://www.terraform.io) Terraform-Plugin-SDK/2.33.0 terraform-provider-google/acc
Content-Length: 1906
Content-Type: application/json
X-Goog-Api-Client: gl-go/1.22.6 gdcl/0.189.0
Accept-Encoding: gzip

{
 "cpuPlatform": "Unknown CPU Platform",
 "creationTimestamp": "2024-08-11T04:16:37.264-07:00",
 "disks": [
  {
   "autoDelete": true,
   "boot": true,
   "deviceName": "persistent-disk-0",
   "diskEncryptionKey": {
    "rawKey": "SGVsbG8gZnJvbSBHb29nbGUgQ2xvdWQgUGxhdGZvcm0="
   },
   "mode": "READ_WRITE",
   "source": "projects/iac-poc-krakow/zones/us-central1-a/disks/tf-test-eadzm2j2ya"
  },
  {
   "deviceName": "persistent-disk-1",
   "diskEncryptionKey": {
    "rawKey": "Ym9vdDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI="
   },
   "mode": "READ_WRITE",
   "source": "projects/iac-poc-krakow/zones/us-central1-a/disks/tf-testd-1civ7c6zzf"
  }
 ],
 "fingerprint": "3AnsKqMjHL0=",
 "id": "5412991932422235003",
 "kind": "compute#instance",
 "labelFingerprint": "42WmSpB8rSM=",
 "lastStartTimestamp": "2024-08-11T04:16:45.904-07:00",
 "lastStopTimestamp": "2024-08-11T04:19:19.546-07:00",
 "machineType": "projects/iac-poc-krakow/zones/us-central1-a/machineTypes/e2-standard-2",
 "metadata": {
  "fingerprint": "tPEd1MbbI8E=",
  "items": [
   {
    "key": "foo",
    "value": "bar"
   }
  ],
  "kind": "compute#metadata"
 },
 "name": "tf-test-eadzm2j2ya",
 "networkInterfaces": [
  {
   "fingerprint": "1i6NyCGLdrE=",
   "kind": "compute#networkInterface",
   "name": "nic0",
   "network": "https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/global/networks/default",
   "networkIP": "10.128.15.192",
   "stackType": "IPV4_ONLY",
   "subnetwork": "https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/regions/us-central1/subnetworks/default"
  }
 ],
 "satisfiesPzi": true,
 "scheduling": {
  "automaticRestart": true,
  "onHostMaintenance": "MIGRATE",
  "provisioningModel": "STANDARD"
 },
 "selfLink": "https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/zones/us-central1-a/instances/tf-test-eadzm2j2ya",
 "shieldedInstanceConfig": {
  "enableIntegrityMonitoring": true,
  "enableVtpm": true
 },
 "shieldedInstanceIntegrityPolicy": {
  "updateAutoLearnPolicy": true
 },
 "status": "TERMINATED",
 "tags": {
  "fingerprint": "42WmSpB8rSM="
 },
 "zone": "https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/zones/us-central1-a"
}

-----------------------------------------------------
2024/08/11 13:19:24 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Sun, 11 Aug 2024 11:19:25 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "error": {
    "code": 400,
    "message": "'projects/iac-poc-krakow/zones/us-central1-a/disks/tf-test-eadzm2j2ya' is protected with a customer supplied encryption key, but none was provided.",
    "errors": [
      {
        "message": "'projects/iac-poc-krakow/zones/us-central1-a/disks/tf-test-eadzm2j2ya' is protected with a customer supplied encryption key, but none was provided.",
        "domain": "global",
        "reason": "resourceIsEncryptedWithCustomerEncryptionKey"
      }
    ]
  }
}

-----------------------------------------------------

It actually doesn't matter what disk is in the error code because any disk having a CSEK will cause a fail on this API call

melinath · 2024-08-12T15:30:49Z

Thanks! Any chance you have a reference link for the API bug?

melinath

Removing from my review queue for now - let me know when you want me to take a look

modular-magician · 2024-08-13T23:03:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 34 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 1 file changed, 34 insertions(+), 27 deletions(-))

modular-magician · 2024-08-13T23:18:31Z

Tests analytics

Total tests: 980
Passed tests: 893
Skipped tests: 72
Affected tests: 15

Click here to see the affected service packages

compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeDisk_storagePoolSpecified

TestAccComputeInstance_bootDisk_storagePoolSpecified

TestAccComputeInstance_diskEncryptionRestart

TestAccComputeInstance_metadataStartupScript_update

TestAccComputeInstance_minCpuPlatform

TestAccComputeInstance_stopInstanceToUpdate

TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate

Get to know how VCR tests work

modular-magician · 2024-08-13T23:24:28Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_metadataStartupScript_update[Debug log]
TestAccComputeInstance_minCpuPlatform[Debug log]
TestAccComputeInstance_stopInstanceToUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_diskEncryptionRestart[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

karolgorc · 2024-08-19T06:40:25Z

I don't think these 2 test fails are related because they pass in my env that's a few commits behind
--- PASS: TestAccComputeDisk_storagePoolSpecified (27.76s)
--- PASS: TestAccComputeInstance_bootDisk_storagePoolSpecified (198.70s)

melinath

removing from my review queue pending API fix

github-actions · 2024-09-03T09:41:31Z

@karolgorc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions · 2024-09-17T09:41:42Z

@karolgorc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

c2thorn · 2024-09-25T19:52:31Z

@karolgorc please see this comment: #11742 (comment)

If you would like assistance converting files, we need your permission to push changes to this branch.

github-actions · 2024-09-27T09:41:56Z

@karolgorc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

c2thorn · 2024-09-27T16:59:56Z

Removing automatic closure to give time to convert to Go & because it looks like this is pending an API fix

add fingerprint fixes, add fetching raw keys before API call change functions used to change min_cpu_platform and machine_type and move them to the same condition Add separate error message for not supported operation on min_cpu_platform parameter

trodge · 2024-09-30T20:48:48Z

There was a merge conflict as I was converting this from Ruby to Go, not sure if I resolved it correctly. The backup branch is here.

Please double-check that the logic is still correct.

modular-magician · 2024-09-30T20:54:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 34 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 1 file changed, 34 insertions(+), 27 deletions(-))

modular-magician · 2024-09-30T21:11:59Z

Tests analytics

Total tests: 1018
Passed tests: 931
Skipped tests: 74
Affected tests: 13

Click here to see the affected service packages

compute

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstance_diskEncryptionRestart

TestAccComputeInstance_metadataStartupScript_update

TestAccComputeInstance_minCpuPlatform

TestAccComputeInstance_stopInstanceToUpdate

TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate

TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate

Get to know how VCR tests work

modular-magician · 2024-09-30T21:18:11Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_metadataStartupScript_update[Debug log]
TestAccComputeInstance_minCpuPlatform[Debug log]
TestAccComputeInstance_stopInstanceToUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate[Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstance_diskEncryptionRestart[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

karolgorc · 2024-10-01T07:13:46Z

This test error is currently expected and waiting for an API fix on instances.Update

TestAccComputeInstance_diskEncryptionRestart

melinath

Removing from my queue pending the API fix.

github-actions bot requested a review from melinath July 30, 2024 09:08

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 30, 2024

melinath reviewed Jul 30, 2024

View reviewed changes

modular-magician added service/compute-instances and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 30, 2024

github-actions bot requested a review from melinath August 6, 2024 10:57

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 6, 2024

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 6, 2024

melinath requested changes Aug 6, 2024

View reviewed changes

github-actions bot requested a review from melinath August 9, 2024 10:49

melinath requested changes Aug 9, 2024

View reviewed changes

github-actions bot requested a review from melinath August 11, 2024 11:48

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 11, 2024

melinath reviewed Aug 13, 2024

View reviewed changes

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 13, 2024

github-actions bot requested a review from melinath August 19, 2024 06:41

melinath reviewed Aug 20, 2024

View reviewed changes

c2thorn added the not-go-migrated label Sep 24, 2024

c2thorn added the disable-automatic-closure label Sep 27, 2024

Convert from Ruby to Go

33a8d24

add fingerprint fixes, add fetching raw keys before API call change functions used to change min_cpu_platform and machine_type and move them to the same condition Add separate error message for not supported operation on min_cpu_platform parameter

trodge force-pushed the min-cpu-platform-error-message branch from 30ec95e to 33a8d24 Compare September 30, 2024 20:33

github-actions bot requested a review from melinath September 30, 2024 20:34

trodge mentioned this pull request Sep 30, 2024

Min cpu platform error message 11289 backup #11872

Draft

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 30, 2024

trodge removed the not-go-migrated label Sep 30, 2024

melinath reviewed Oct 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add separate error message for not supported operation on min_cpu_platform #11289

Add separate error message for not supported operation on min_cpu_platform #11289

karolgorc commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024

melinath left a comment

modular-magician commented Jul 30, 2024

modular-magician commented Jul 30, 2024

khajduczenia commented Aug 2, 2024

melinath commented Aug 2, 2024

melinath commented Aug 2, 2024

karolgorc commented Aug 6, 2024 •

edited

Loading

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

melinath left a comment

karolgorc commented Aug 9, 2024

melinath left a comment

karolgorc commented Aug 11, 2024

melinath commented Aug 12, 2024

melinath left a comment

modular-magician commented Aug 13, 2024

modular-magician commented Aug 13, 2024

modular-magician commented Aug 13, 2024

karolgorc commented Aug 19, 2024

melinath left a comment

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 17, 2024

c2thorn commented Sep 25, 2024

github-actions bot commented Sep 27, 2024

c2thorn commented Sep 27, 2024

trodge commented Sep 30, 2024

modular-magician commented Sep 30, 2024

modular-magician commented Sep 30, 2024

modular-magician commented Sep 30, 2024

karolgorc commented Oct 1, 2024

melinath left a comment

Add separate error message for not supported operation on min_cpu_platform #11289

Are you sure you want to change the base?

Add separate error message for not supported operation on min_cpu_platform #11289

Conversation

karolgorc commented Jul 30, 2024 • edited Loading

github-actions bot commented Jul 30, 2024

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Jul 30, 2024

Diff report

modular-magician commented Jul 30, 2024

Tests analytics

khajduczenia commented Aug 2, 2024

melinath commented Aug 2, 2024

melinath commented Aug 2, 2024

karolgorc commented Aug 6, 2024 • edited Loading

modular-magician commented Aug 6, 2024

Diff report

modular-magician commented Aug 6, 2024

Tests analytics

Action taken

modular-magician commented Aug 6, 2024

melinath left a comment

Choose a reason for hiding this comment

karolgorc commented Aug 9, 2024

melinath left a comment

Choose a reason for hiding this comment

karolgorc commented Aug 11, 2024

melinath commented Aug 12, 2024

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 13, 2024

Diff report

modular-magician commented Aug 13, 2024

Tests analytics

Action taken

modular-magician commented Aug 13, 2024

karolgorc commented Aug 19, 2024

melinath left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 17, 2024

c2thorn commented Sep 25, 2024

github-actions bot commented Sep 27, 2024

c2thorn commented Sep 27, 2024

trodge commented Sep 30, 2024

modular-magician commented Sep 30, 2024

Diff report

modular-magician commented Sep 30, 2024

Tests analytics

Action taken

modular-magician commented Sep 30, 2024

karolgorc commented Oct 1, 2024

melinath left a comment

Choose a reason for hiding this comment

karolgorc commented Jul 30, 2024 •

edited

Loading

karolgorc commented Aug 6, 2024 •

edited

Loading