Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about user_project_override in google_firebase_project #11266

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

rainshen49
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#18668

Release Note Template for Downstream PRs (will be copied)

firebase: Documentation only

@github-actions github-actions bot requested a review from trodge July 26, 2024 14:53
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@rainshen49
Copy link
Contributor Author

@trodge This is a trivial change. Feel free to approve without service team review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_firebase_project should mention the need for user_project_override provider flag
3 participants