Implementing IAP Settings in Terraform

[Deepraj1996]

This PR is to add IAP Settings support is Terraform Google provider, request is already being added in Issue tracker hashicorp/terraform-provider-google#6471

This PR is adding a new resource "IAP_Settings" in product IAP and it does not exist in GA provider and Beta provider.

`google_iap_settings`

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2027 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2027 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 147 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• iap

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_update
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2013 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 147 insertions(+))

[modular-magician]

Tests analytics

Total tests: 87
Passed tests: 59
Skipped tests: 20
Affected tests: 8

Click here to see the affected service packages

• iap

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIapAppEngineServiceIamBindingGenerated
• TestAccIapAppEngineServiceIamBindingGenerated_withCondition
• TestAccIapAppEngineServiceIamMemberGenerated
• TestAccIapAppEngineServiceIamMemberGenerated_withCondition
• TestAccIapAppEngineServiceIamPolicyGenerated
• TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccIapSettings_iapSettingsBasicExample[Error message] [Debug log]
TestAccIapSettings_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2046 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2046 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 581 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    allowed_domains_settings {
      domains = # value needed
      enable  = # value needed
    }
    gcip_settings {
      login_page_uri = # value needed
      tenant_ids     = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
  application_settings {
    attribute_propagation_settings {
      expression = # value needed
    }
    cookie_domain = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• iap

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_update
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2046 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2046 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 581 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    allowed_domains_settings {
      domains = # value needed
      enable  = # value needed
    }
    gcip_settings {
      login_page_uri = # value needed
      tenant_ids     = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
  application_settings {
    attribute_propagation_settings {
      expression = # value needed
    }
    cookie_domain = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 87
Passed tests: 59
Skipped tests: 20
Affected tests: 8

Click here to see the affected service packages

• iap

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIapAppEngineServiceIamBindingGenerated
• TestAccIapAppEngineServiceIamBindingGenerated_withCondition
• TestAccIapAppEngineServiceIamMemberGenerated
• TestAccIapAppEngineServiceIamMemberGenerated_withCondition
• TestAccIapAppEngineServiceIamPolicyGenerated
• TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccIapSettings_iapSettingsBasicExample[Error message] [Debug log]
TestAccIapSettings_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2027 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2027 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 581 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 159 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    allowed_domains_settings {
      domains = # value needed
      enable  = # value needed
    }
    gcip_settings {
      login_page_uri = # value needed
      tenant_ids     = # value needed
    }
    identity_sources = # value needed
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
  application_settings {
    attribute_propagation_settings {
      expression = # value needed
    }
    cookie_domain = # value needed
  }
}

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 79
Passed tests: 61
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages

• iap

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2099 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2099 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

[zli82016]

The PR has been migrated.

[modular-magician]

Tests analytics

Total tests: 79
Passed tests: 61
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages

• iap

🟢 All tests passed!

View the build log