Add Compliance Config to the default cluster config field of the Fleet resource.

[tonyzhc]

Add Compliance Config to the default cluster config field of the Fleet resource. Fixes b/330782787.

Release Note Template for Downstream PRs (will be copied)

gkehub2: added `compliance_config` field to `google_gke_hub_fleet` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+))
google-beta provider: Diff ( 3 files changed, 315 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+))
google-beta provider: Diff ( 3 files changed, 315 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccGKEHub2Fleet_gkehubFleetWithComplianceConfig_update
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+))
google-beta provider: Diff ( 3 files changed, 315 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccGKEHub2Fleet_gkehubFleetWithComplianceConfig_update
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[shuyama1]

Suggested change

	Config: testAccContainerCluster_EnableComplianceConfigWithDefaultStandards(clusterName, networkName, subnetworkName),
	Config: testAccContainerCluster_EnableComplianceConfigWithDefaultStandards(context),

Tests and checks failed due to error like

Error: google-beta/services/gkehub2/resource_gke_hub_fleet_test.go:37:80: undefined: clusterName
Error: google-beta/services/gkehub2/resource_gke_hub_fleet_test.go:37:93: undefined: networkName
Error: google-beta/services/gkehub2/resource_gke_hub_fleet_test.go:37:93: too many arguments in call to testAccContainerCluster_EnableComplianceConfigWithDefaultStandards

We may also need to update the rest of tests as well

[github-actions]

@tonyzhc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@tonyzhc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[c2thorn]

Hi @tonyzhc

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself after the migration. You can view a preview branch and updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

[tonyzhc]

Hi @c2thorn, I give you permission to force push the commit to my fork's branch. This PR is on-hold for some of the changes on our side anyway.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+))
google-beta provider: Diff ( 3 files changed, 315 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccGKEHub2Fleet_gkehubFleetWithComplianceConfig_update
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shuyama1]

Rolling a new reviewer as I'm OOO this week. Adding disable-review-reminders given the PR is on-hold according to #10487 (comment)

[melinath]

@tonyzhc is the hold expected to be longer than 6 weeks?

[tonyzhc]

@melinath no, I should have a better idea by end of October.

[melinath]

removing from my queue for now

[shuyama1]

@tonyzhc Would you mind if I convert this PR to draft for now since the change is on hold? You can mark it as ready for review or just ping me when it's ready ready. Thank you!

[github-actions]

@tonyzhc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.